From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 299383B2A4 for ; Sun, 17 Nov 2019 15:25:04 -0500 (EST) Received: by mail-lj1-x242.google.com with SMTP id t5so16438607ljk.0 for ; Sun, 17 Nov 2019 12:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ql6OPsK4uQYSkaAsGyBu94gd3BNPrccgvPAvpalrUQQ=; b=ZPoAuICAkjxKQgHPGL+AyFKDAZTJ/RODCKSZyZQsYEh6LdpYJ/u7vQiYPUhupoMhAI TlD7L+W4j7LiGb5I2eAx0CQx9DiuZU7b1QNUf/MfGqFG80Y9tEAjsYnQ/dsXRzRg94h8 NitnzK7p10yjnqfmVLUcJQ4eomZ7v/gDqJ2Re3wBqMj1bODmxZriGDwDv1uIgaNM2kkQ Awwkc7Qfn/XIp6GZ6NDZhrqbOXidR9ye1RLt1BJ4D9XGvQif3RCskt37XF7D3QDSzhJW MtqwO2us/w5OYOraunBCV9PLbSzJvChKRQ6H+6/5g/0mcWzleihT04816Yzwu8LQPqO3 8Ytg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ql6OPsK4uQYSkaAsGyBu94gd3BNPrccgvPAvpalrUQQ=; b=kB8OmRmwegdr5ZYh80VnzbvaMRZRqFPdAXDyJh3nRNSPya5ymS7wdSRtWlPkn+CDSd mPoDqQ4KVUJlYHaMGl+EjpVnXOMQ/BytJJPvmfKpAhShBolgMAyiirCBqkKEZF6a9SSj 4WQWGvvBbhIjgZwfRJHmxotDlyPdhaoFruthjRxk9bK22tseC4AVWQbsDXJlfv6KXOXY fT87C9fM/VBoxjiElfrLReaR+6EFP9APhrrAIbIzxmd+4LVeYOSYLjU9Ns4n5oxO5XMX z4C+8ly/bF2fI53+dn7omTPR+WXagU5IDJixGGT8TDO/B3VNfBPSwIM4C03B9DSGLgz8 EPeg== X-Gm-Message-State: APjAAAVl/HvM+A+y1+q1I3DdA+eI+kevloWvlkhWV8nBm/qBli9vyDo1 mKP3+rxq/cF/5vwzQNIhg+CFNme4w4opuigjKQuxiw== X-Google-Smtp-Source: APXvYqxzsZMoMt7ussfhZ81q9Qzzfp+hPUHwHwDwXa5B5t/Rm64rKUAT1TzDysvU7bbQyn5VqFKYBy5YQFLS8gcB4N0= X-Received: by 2002:a2e:9ad8:: with SMTP id p24mr7233950ljj.114.1574022302590; Sun, 17 Nov 2019 12:25:02 -0800 (PST) MIME-Version: 1.0 References: <157382403672.580235.12525941420808058808.stgit@toke.dk> <157382404118.580235.14216392299709793599.stgit@toke.dk> <87y2wgjas4.fsf@toke.dk> In-Reply-To: <87y2wgjas4.fsf@toke.dk> From: Kan Yan Date: Sun, 17 Nov 2019 12:24:51 -0800 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Johannes Berg , linux-wireless , Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v9 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Nov 2019 20:25:04 -0000 > > Given the fact that AQL is only tested in very limited platforms, > > should we set the default to disabled by removing this change in the > > next update? > > > > - local->airtime_flags =3D AIRTIME_USE_TX | AIRTIME_USE_RX; > > + > > + local->airtime_flags =3D AIRTIME_USE_TX | > > + AIRTIME_USE_RX | > > + AIRTIME_USE_AQL; > > + local->aql_threshold =3D IEEE80211_AQL_THRESHOLD; > > + atomic_set(&local->aql_total_pending_airtime, 0); > Well, we have the whole -rc series to get more testing in if we merge it > as-is. It's up to the maintainers, of course, but I would be in favour > of merging as-is, then optionally backing out the default before the > final release if problems do turn up. But I would hope that the limits > are sufficiently conservative that it would not result in any problems :) Sounds good. The current default limits are reasonably conservative and are tunable via debugfs. I will give the v10 version of this patch serial a quick test and hopefully we can wrap it up soon. -Kan On Sat, Nov 16, 2019 at 3:55 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Kan Yan writes: > > >> +static inline u16 > >> +ieee80211_info_set_tx_time_est(struct ieee80211_tx_info *info, u16 tx= _time_est) > >> +{ > >> + /* We only have 10 bits in tx_time_est, so store airtime > >> + * in increments of 4us and clamp the maximum to 2**12-1 > >> + */ > >> + info->tx_time_est =3D min_t(u16, tx_time_est, 4095) >> 2; > >> + return info->tx_time_est; > >> +} > >> + > >> +static inline u16 > >> +ieee80211_info_get_tx_time_est(struct ieee80211_tx_info *info) > >> +{ > >> + return info->tx_time_est << 2; > >> +} > >> + > > > > set_tx_time_est() returns airtime in different units (4us) than > > get_tx_time_est(), this will cause the pending_airtime out of whack. > > Huh, you're quite right; oops! I meant to shift that back before > returning. Will fix. > > > Given the fact that AQL is only tested in very limited platforms, > > should we set the default to disabled by removing this change in the > > next update? > > > > - local->airtime_flags =3D AIRTIME_USE_TX | AIRTIME_USE_RX; > > + > > + local->airtime_flags =3D AIRTIME_USE_TX | > > + AIRTIME_USE_RX | > > + AIRTIME_USE_AQL; > > + local->aql_threshold =3D IEEE80211_AQL_THRESHOLD; > > + atomic_set(&local->aql_total_pending_airtime, 0); > > Well, we have the whole -rc series to get more testing in if we merge it > as-is. It's up to the maintainers, of course, but I would be in favour > of merging as-is, then optionally backing out the default before the > final release if problems do turn up. But I would hope that the limits > are sufficiently conservative that it would not result in any problems :) > > -Toke >