From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 836F83B260 for ; Wed, 17 Aug 2016 16:07:49 -0400 (EDT) Received: by mail-it0-x243.google.com with SMTP id f6so289255ith.2 for ; Wed, 17 Aug 2016 13:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1FE+vlhrkDxwp6Fjw0ptGaiJnzcD8esJLAvsEr7jiCs=; b=hHhHRxTGwQbR3JqRC7zHd4unZmee43NwaJP3Up0PtgX/EblhpDUzBf93wnTLFOeKDk gqscm6nFC3i0ypXrK1hqSbZAk1XKyC7hNBoD6XZP7D5Ejny4JFF6ZArZEEu0FT7a55Zh 159Hm1EJI0AvgysSgqnTtyFyCOuPvNIcOrXvtWTeZba0xF546VA9MmtnyQfiWXlXlLgo CGYBj6s4lsJkLmtGL6J0nl5CKzvWiF12AGDLggD3rVniroRpkNi+cjDe787Ve0uYSD/C xQOrLVJej/9WCEbCEZbQ30eEV3vMWDYRbXUCodtV81pZSYrhCus2kxrwCBay/qLy2Hxy Z+pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1FE+vlhrkDxwp6Fjw0ptGaiJnzcD8esJLAvsEr7jiCs=; b=LbaMUyQ++H6YD/9ZJThXEbf5lWsRnE/n8eYrbTj36esMaMYBKXP2m0zvtcV/HIyfC5 he/44FTxl76YDX+sHwy7CovvLTgipqNHMISsivC03KY6qElwfdenMWe12AHz92OsZXpm RcqKE71TrA4RmlSwsI4YUsut4dGBmKhpoGQRMBTk5/4Ym0j8Ma2JvBKkweHQm4kNW4/+ 6ecPzgbWkLk9jIeTc7c4EAJ0DjDzb0g46AF/bftXQh0aZ+nY2UKXJG/TRmFeJCud6R3F 8rZeki9FOrvBE+PvZnhCeaLgQWd+uZ0u02evTcIlpNgpQWi/5VfhEOo7PiWRgPR6uCFs lang== X-Gm-Message-State: AEkoouuwWHGFWWZSfRYn6OmGgvz35gCs7oTOUigqo00hMwL7QEGx6dVv6GGvv4ulPqA+X/Gw5pdVUR9W/DitaA== X-Received: by 10.36.217.9 with SMTP id p9mr31338466itg.46.1471464468917; Wed, 17 Aug 2016 13:07:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.13.200 with HTTP; Wed, 17 Aug 2016 13:07:48 -0700 (PDT) In-Reply-To: <1471463348.5173.16.camel@sipsolutions.net> References: <20160817125800.19154-1-toke@toke.dk> <20160817144531.4285-1-toke@toke.dk> <1471463348.5173.16.camel@sipsolutions.net> From: Dave Taht Date: Wed, 17 Aug 2016 22:07:48 +0200 Message-ID: To: Johannes Berg Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless , Felix Fietkau Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v2] mac80211: Move crypto IV generation to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 20:07:49 -0000 On Wed, Aug 17, 2016 at 9:49 PM, Johannes Berg wrote: > Hi, > > You need to work on coding style, a lot of your indentation is > completely messed up. > >> + switch (sdata->vif.type) { >> + case NL80211_IFTYPE_STATION: >> + if (sdata->u.mgd.use_4addr) { >> + pn_offs =3D 30; >> + break; >> + } >> + pn_offs =3D 24; >> + break; >> + case NL80211_IFTYPE_AP_VLAN: >> + if (sdata->wdev.use_4addr) { >> + pn_offs =3D 30; >> + break; >> + } >> + /* fall through */ >> + case NL80211_IFTYPE_ADHOC: >> + case NL80211_IFTYPE_AP: >> + pn_offs =3D 24; >> + break; >> + default: >> + return; >> + } >> + >> + if (sta->sta.wme) { >> + pn_offs +=3D 2; >> + } > > I think you just reinvented ieee80211_hdrlen(). No? > >> - if (fast_tx->pn_offs) { >> - u64 pn; >> - u8 *crypto_hdr =3D skb->data + fast_tx->pn_offs; > > No need to undo the pn_offs optimisation for the !txq case, you can > pass it in to the new function that will fill it. > > However, you're still doing it wrong - now you haven't fixed anything > for TKIP, which won't hit the fastpath. well, we're getting there. the results of both patch attempts were really nice, and brought encrypted performance with fq back into line with unencrypted. Still running crypted tests as I write... So fixing TKIP would be next, forcing the AP to use that? What other scenarios do we have to worry about? WDS? > johannes > _______________________________________________ > Make-wifi-fast mailing list > Make-wifi-fast@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/make-wifi-fast --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org