From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x235.google.com (mail-qt0-x235.google.com [IPv6:2607:f8b0:400d:c0d::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 30BA33B2A3 for ; Wed, 18 Jan 2017 16:28:48 -0500 (EST) Received: by mail-qt0-x235.google.com with SMTP id x49so32070957qtc.2 for ; Wed, 18 Jan 2017 13:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=4GtZpKM3WzwPZ568qEhrhqJp6aD4XXDnq6RooYhRFPs=; b=TFVcbiVT6smG9RTuf3B2jfvFvqTdLW7rq81A7hO/uDKXEpC0rMva1mDVr3LKxDJg9D /qawimxfXOK6MJrkYD7A/AoIPd9GeXY3+n4QPC37fXiemevI8RF/Ti+BGSu4S3GJJugD QZLtR9YNFMusBM85OM69fiuiB6T1NuueGeTzfsfWPSG+N+vAUccAMUSFbg0hze2FJFqq wBqx5j88HWbVI5c7YWw6zxktKuzs1C2fY5HR4uQwbWGqAT/maNqGx0j9UNI53l6fqCst miBHKV6r3kkVO6rcoplasAK1VqzlYhtxDpowHNl5+lIldG9C2T8XmbefYIcKTr7oIUKy 4Cug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=4GtZpKM3WzwPZ568qEhrhqJp6aD4XXDnq6RooYhRFPs=; b=c+c5E7pBaEx3ZLkOaP/C17LXdxK8D/mYFtpZ8RIRaGvTPFyVMw50ktBEfWtgCWNoA+ FaJH11VQk6VxIQRpzb3O19J+JXu1nFx/IFAvc3H8b8EoIuTf3OdD1wXB7d5pKVPP0p4u 12fizL7aqpVz/kSnT8uo6SIPyLFBn5vMczoZL0ISJjkqgq30v4T4g9nKLSwSk05e83O/ tsv6OJtIs9DNeH9XEwkWwGIYhOT6iuCy8yCmhWSlOD4i1fTvhH9cmatv8uiad9WnRKAh jxNYL6Q+qvbhihgRSnltyt5Vq4akIN1r3HzY7KyDU17msjpqKKEtONahLazxSZMzQoxv hclw== X-Gm-Message-State: AIkVDXItXFhRCBTO5k8IHk67N8+qyZs+mwcmboPqlk+0PGFdkNpC8Hhnr5JtTU8pV8ZfhzKJhw2H7xacpgWoqA== X-Received: by 10.55.5.148 with SMTP id 142mr4925910qkf.262.1484774927709; Wed, 18 Jan 2017 13:28:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.152.197 with HTTP; Wed, 18 Jan 2017 13:28:47 -0800 (PST) From: Dave Taht Date: Wed, 18 Jan 2017 13:28:47 -0800 Message-ID: To: Jon Pike Cc: make-wifi-fast@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] Fwd: [PATCH] mac80211: prevent skb/txq mismatch X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 21:28:48 -0000 If everybody could track their experiences here, that would help. https://bugs.lede-project.org/index.php?do=3Ddetails&task_id=3D368 On Wed, Jan 18, 2017 at 9:38 AM, Jon Pike wrote: > And, it is probably worth mentioning that I also have IPV6 routing > disabled, after what seemed like an issue with a local device being overl= y > chatty. > > Have also reread a bit, and see that Jan 3 or 4 seems to be the date of = ATF > removal, so I assume I still have it. > > On Jan 18, 2017 9:00 AM, > wrote: > > Send Make-wifi-fast mailing list submissions to > make-wifi-fast@lists.bufferbloat.net > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.bufferbloat.net/listinfo/make-wifi-fast > or, via email, send a message with subject or body 'help' to > make-wifi-fast-request@lists.bufferbloat.net > > You can reach the person managing the list at > make-wifi-fast-owner@lists.bufferbloat.net > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Make-wifi-fast digest..." > > Today's Topics: > > 1. Re: Fwd: [PATCH] mac80211: prevent skb/txq mismatch (Jon Pike) > > > > ---------- Forwarded message ---------- > From: Jon Pike > To: make-wifi-fast@lists.bufferbloat.net > Cc: > Date: Tue, 17 Jan 2017 22:58:30 -0800 > Subject: Re: [Make-wifi-fast] Fwd: [PATCH] mac80211: prevent skb/txq > mismatch > I'm pretty clueless on this, but as a single data point, my Archer C7 ha= s > abt 21 days of uptime now, since my last update, as the single router in = a 4 > person household. I've been running cake/piece of cake the whole time. > > Standard disclaimers apply as to clueless user not knowing if his FW vers= ion > has anything to do with the issue in question, or if its connected to oth= er > things like whatever is going on with the airtime fairness. But the comm= ent > in the third paragraph sounded interesting in light of my lack of a crash > and running a SQM method, FWIW. > > My last update was a sysupgrade to LEDE Reboot SNAPSHOT r2687-dc5f496 pre= tty > sure date was 12-27-16. > > > Today's Topics: > > 1. Fwd: [PATCH] mac80211: prevent skb/txq mismatch (Dave Taht) > > > ---------- Forwarded message ---------- > From: Dave Taht > To: make-wifi-fast@lists.bufferbloat.net > Cc: > Date: Thu, 12 Jan 2017 10:44:12 -0800 > Subject: [Make-wifi-fast] Fwd: [PATCH] mac80211: prevent skb/txq mismatch > yea! (I think) > > > ---------- Forwarded message ---------- > From: Michal Kazior > Date: Thu, Jan 12, 2017 at 6:28 AM > Subject: [PATCH] mac80211: prevent skb/txq mismatch > To: johannes@sipsolutions.net > Cc: linux-wireless@vger.kernel.org, greearb@candelatech.com, > mohammed@qti.qualcomm.com, Michal Kazior > > > Station structure is considered as not uploaded > (to driver) until drv_sta_state() finishes. This > call is however done after the structure is > attached to mac80211 internal lists and hashes. > This means mac80211 can lookup (and use) station > structure before it is uploaded to a driver. > > If this happens (structure exists, but > sta->uploaded is false) fast_tx path can still be > taken. Deep in the fastpath call the sta->uploaded > is checked against to derive "pubsta" argument for > ieee80211_get_txq(). If sta->uploaded is false > (and sta is actually non-NULL) ieee80211_get_txq() > effectively downgraded to vif->txq. > > At first glance this may look innocent but coerces > mac80211 into a state that is almost guaranteed > (codel may drop offending skb) to crash because a > station-oriented skb gets queued up on > vif-oriented txq. The ieee80211_tx_dequeue() ends > up looking at info->control.flags and tries to use > txq->sta which in the fail case is NULL. > .......... > > _______________________________________________ > Make-wifi-fast mailing list > Make-wifi-fast@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/make-wifi-fast > > > > _______________________________________________ > Make-wifi-fast mailing list > Make-wifi-fast@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/make-wifi-fast > > > > _______________________________________________ > Make-wifi-fast mailing list > Make-wifi-fast@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/make-wifi-fast --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org