From: Dave Taht <dave.taht@gmail.com>
To: Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>
Subject: [Make-wifi-fast] codel params in net-next
Date: Mon, 5 Aug 2019 15:47:12 -0700 [thread overview]
Message-ID: <CAA93jw4r=zLd4iTX7Ge7-wAYPu6PQDfWmr664bBKJczaRHK0Hg@mail.gmail.com> (raw)
I remember that this bit in sta_info.c was hacky. But in testing today
I'd seen drops
where I'd expected ecn, and didn't know it turned it off!
I was also thinking this triggered a bit too often with multiple
stations, and perhaps sta->local->num_sta should be an ewma of the
most recently transmitted stations or some other value. Am I
misunderstanding what num_sta is?
static void sta_update_codel_params(struct sta_info *sta, u32 thr)
{
if (!sta->sdata->local->ops->wake_tx_queue)
return;
if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {
--
Dave Täht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-205-9740
next reply other threads:[~2019-08-05 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 22:47 Dave Taht [this message]
2019-08-08 18:30 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA93jw4r=zLd4iTX7Ge7-wAYPu6PQDfWmr664bBKJczaRHK0Hg@mail.gmail.com' \
--to=dave.taht@gmail.com \
--cc=make-wifi-fast@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox