From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dave.taht@gmail.com>
Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com
 [IPv6:2607:f8b0:4864:20::336])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 7F6883CB37
 for <make-wifi-fast@lists.bufferbloat.net>;
 Mon,  5 Aug 2019 18:47:24 -0400 (EDT)
Received: by mail-ot1-x336.google.com with SMTP id n5so87884032otk.1
 for <make-wifi-fast@lists.bufferbloat.net>;
 Mon, 05 Aug 2019 15:47:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to
 :content-transfer-encoding;
 bh=aZHDcm1LuZu2ADkxw4877oqPXk7s1Yr/s/J1TbjrlBk=;
 b=d8r3Bwzu4ScNUdPLFo7cO5+miUJkFzcGkZTIAyoyKTFQub+fF+G9rqBdbjcL5yNDOO
 EXMvQ8eNF+1sEzIx33d2jWje65TS9hbgcR6koKT3ejLHNN1Eje3yxs+ruVymiXErfbJU
 P35uWwz7kH5FkaxSDZRlrNFh/Ns5McZU0W2KdLBzV3aTPD6H0zQ1EnaHg3WM/ROVaIlm
 yoAL+4I3kBnjypOHLbY7cqbj2ZEL9XJVIOZppFH5pv7LWCrwF0yKz+svfnxdkUpy9DKf
 w62wxw5w7m6ry2yN0NUi+yTvEuP4mM4b4lBtigDEU2ujshoQ39O963VLeE1RCCQwSXZp
 hcRQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to
 :content-transfer-encoding;
 bh=aZHDcm1LuZu2ADkxw4877oqPXk7s1Yr/s/J1TbjrlBk=;
 b=Y4j5qbqlIwj/maECxYJgZED+u40xuOzYN8D48qZR8Rp4yr99ZxjiPqPPGO2IB5nh2a
 AhVceuVqfFsuDvMTG4tcQbzD75K1kETHj75cw6Ua2U84jHlU4sKthd8PRG46/CfvHplo
 vpxolcZaAA6znm5kgrc1BGYcAX1noACc11dcF6AmqnUrI7cDGfDQIBpIY/AEZtCtjVHI
 Fbr7Qzvz9Wau0rmrtlsidhsaLeFb01smp2D2HfQBsxVOG5baStuPHY8/BVA4SDcbFNOH
 rnb8d3xkg+Fz7LBp8jeNjWhQdNJIj53700MpEV2QYf0hGBiLRpae0XRf/DLFMw0Yd4AT
 9BkQ==
X-Gm-Message-State: APjAAAVLzBQx28UutI2nScVzjYn1yIgot3E0j7MBalSzP2r7PCY91K3y
 IZyza5SSQ/E6A7lo4PVxjsrt3JTUHAryajwl2/Hx4ull
X-Google-Smtp-Source: APXvYqx65pbKHbLMosRnF2VOkP+Nug0RZXbl1J0BjURqbX6XFIYu9qPM0dzSrZLyEPZzEq1L3fYjItwfvqD9znbqLxY=
X-Received: by 2002:a6b:cd07:: with SMTP id d7mr381785iog.150.1565045243543;
 Mon, 05 Aug 2019 15:47:23 -0700 (PDT)
MIME-Version: 1.0
From: Dave Taht <dave.taht@gmail.com>
Date: Mon, 5 Aug 2019 15:47:12 -0700
Message-ID: <CAA93jw4r=zLd4iTX7Ge7-wAYPu6PQDfWmr664bBKJczaRHK0Hg@mail.gmail.com>
To: Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: [Make-wifi-fast] codel params in net-next
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Mon, 05 Aug 2019 22:47:24 -0000

I remember that this bit in sta_info.c was hacky. But in testing today
I'd seen drops
where I'd expected ecn, and didn't know it turned it off!

I was also thinking this triggered a bit too often with multiple
stations, and perhaps sta->local->num_sta should be an ewma of the
most recently transmitted stations or some other value. Am I
misunderstanding what num_sta is?

static void sta_update_codel_params(struct sta_info *sta, u32 thr)
{
        if (!sta->sdata->local->ops->wake_tx_queue)
                return;

        if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {



--=20

Dave T=C3=A4ht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-205-9740