From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x231.google.com (mail-qt0-x231.google.com [IPv6:2607:f8b0:400d:c0d::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3138F3B2AE for ; Sun, 25 Sep 2016 14:19:03 -0400 (EDT) Received: by mail-qt0-x231.google.com with SMTP id 38so72569997qte.1 for ; Sun, 25 Sep 2016 11:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=vnTM0HJtfo4p/nBSZ6H745UzxCVqG4px9JA3WTYEm0E=; b=aLTItLKh2Sa6Es2cvGXCpO2WGp0rcF4SOxT422glRXhNlS3EasQZ8mSNZ7XKaK39/4 5lFK7MrjkaY9kxNWAZLloCiW8C/AfDru4vwmlpuHOB+XuFrVgnz2ZyKS/85hV7U83bXY 42so16NiooaNFtkZPVT9dnxaTIXR/L145UgzyFMqGrAM5lsfzKmyi5tXyXTWG1FjNAVJ tuKbxcflf+J9KtI72CA07z1GyS93jCUMHWg8hJIRxfKF/3EvLk4SV/yjA0GyqXjXggpo Neyn2nTVKuv/vdryFjOUplLGUj/3D24p0AVQkGOaAh6uoDimP3FZsyyVqQSkYnOApNs7 25NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=vnTM0HJtfo4p/nBSZ6H745UzxCVqG4px9JA3WTYEm0E=; b=g2+/VsJyTZWNw+q/FLUAj097oaLlGJhByg2R4ATMO2/A7ryzTazHqmJP7uJSxrc5cf XoPjLjE/rcLJAEuxyqUWdQNl0/BJMVFAPTfbxvUtjdvtQtM7+c1hZw/CF4T3EdPaA4nv MPplDj8WCOMx7Pgz9qkgLR6e0q0TbxXB+KXWjAI0MU9owpY2fA+4w0m0lS/8mX/LsweO fZKK2vhvB2/otrULwNm1tgdsu4b4odTza0OAd+PRLkAktMwkZzmc3Eqd6p5XlxFl+kMy r7M5f9G+Fn/0MrWma/yVWyf+eYq6Ce+e6vAA44HhDJ4bXmpdZa/rDgQtSOfiNmHmMMRz tslg== X-Gm-Message-State: AA6/9RnpXWIKVfmhkKmwC1Wg67KtAVcO9jayYjKNRBd/A9mt29PdrIhfnLs148q6Vy+6J77HoYK/aIFocSd5wQ== X-Received: by 10.237.37.170 with SMTP id x39mr3805848qtc.148.1474827542736; Sun, 25 Sep 2016 11:19:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.137.214 with HTTP; Sun, 25 Sep 2016 11:19:02 -0700 (PDT) In-Reply-To: <1474821596-12155-1-git-send-email-michael-dev@fami-braun.de> References: <1474821596-12155-1-git-send-email-michael-dev@fami-braun.de> From: Dave Taht Date: Sun, 25 Sep 2016 11:19:02 -0700 Message-ID: To: Michael Braun , make-wifi-fast@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH 0/3] mac80211: multicast with AP_VLAN optimizations X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2016 18:19:03 -0000 Dear Michael: This looks pretty cool. I have a modified airtime analyzer over here, (courtesy simon and sven) that counts all the airtime used in a capture, that might be useful in analyzing the new behavior. We used it to tear apart the airtime fairness stuff we're doing, and I'd objected to the original code because it filtered out too much multicast. Now (I think) - it counts all of it. https://github.com/dtaht/airtime-pie-chart One minor objection to what I see in this patch is that I've generally thought (not backed by data!) that multicasting vs unicasting was not a binary choice, that at some X number of stations it made sense to fall back to multicast, and that maybe a better way was to chose the highest possible (from data) multicast rate rather than a static one. A possibly larger objection is that converting everything to essentially "reliable multicast" is going to break the assumptions of many a wifi routing protocol - which I don't mind, those assumptions generally suck. One of my tools for measuring multicast behaviors has been "uftp". On Sun, Sep 25, 2016 at 9:39 AM, Michael Braun wrote: > Hi, > > this series tries to optimize multicast delivery on access points with > AP_VLAN interfaces. > > My setup is as follows: hostapd creates one AP_VLAN interface per station > (per_sta_vif=3D1), which enables bridge igmp snooping to decide which > stations need to receive a multicast packet. > > This series then > - avoids multicast packets by tracking the number of authenticated > stations per interface more accurately and drops packets if there is n= o > receiver connected, > - converts multicast packets to unicast packets for the most common > protocols, so they get delivered faster and more reliable. Additionall= y, > waking up non-receivers in other VLANs is avoided. > - speeds up station lookup if there is only one authenticated station > assigned to the AP_VLAN interface. > > Sincerely, > M. Braun > > Michael Braun (3): > mac80211: filter multicast data packets on AP / AP_VLAN > mac80211: multicast to unicast conversion > mac80211: cache the only AP_VLAN station > > net/mac80211/cfg.c | 26 +++++----- > net/mac80211/debugfs_netdev.c | 38 ++++++++++++++ > net/mac80211/ieee80211_i.h | 61 ++++++++++++++++++++++ > net/mac80211/rx.c | 5 +- > net/mac80211/sta_info.c | 41 +++++++++++---- > net/mac80211/tx.c | 115 ++++++++++++++++++++++++++++++++++++= ++++-- > 6 files changed, 258 insertions(+), 28 deletions(-) > > -- > 2.1.4 > --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org