Re: [Make-wifi-fast] [PATCH 0/3] mac80211: multicast with AP_VLAN optimizations

Re: [Make-wifi-fast] [PATCH 0/3] mac80211: multicast with AP_VLAN optimizations

[Dave Taht]

Dear Michael:

This looks pretty cool. I have a modified airtime analyzer over here,
(courtesy simon and sven) that counts all the airtime used in a
capture, that might be useful in analyzing the new behavior. We used
it to tear apart the airtime fairness stuff we're doing, and I'd
objected to the original code because it filtered out too much
multicast. Now (I think) - it counts all of it.

https://github.com/dtaht/airtime-pie-chart

One minor objection to what I see in this patch is that I've generally
thought (not backed by data!) that multicasting vs unicasting was not
a binary choice, that at some X number of stations it made sense to
fall back to multicast, and that maybe a better way was to chose the
highest possible (from data) multicast rate rather than a static one.

A possibly larger objection is that converting everything to
essentially "reliable multicast" is going to break the assumptions of
many a wifi routing protocol - which I don't mind, those assumptions
generally suck.

One of my tools for measuring multicast behaviors has been "uftp".

On Sun, Sep 25, 2016 at 9:39 AM, Michael Braun
<michael-dev@fami-braun.de> wrote:
> Hi,
>
> this series tries to optimize multicast delivery on access points with
> AP_VLAN interfaces.
>
> My setup is as follows: hostapd creates one AP_VLAN interface per station
> (per_sta_vif=1), which enables bridge igmp snooping to decide which
> stations need to receive a multicast packet.
>
> This series then
>  - avoids multicast packets by tracking the number of authenticated
>    stations per interface more accurately and drops packets if there is no
>    receiver connected,
>  - converts multicast packets to unicast packets for the most common
>    protocols, so they get delivered faster and more reliable. Additionally,
>    waking up non-receivers in other VLANs is avoided.
>  - speeds up station lookup if there is only one authenticated station
>    assigned to the AP_VLAN interface.
>
> Sincerely,
> M. Braun
>
> Michael Braun (3):
>   mac80211: filter multicast data packets on AP / AP_VLAN
>   mac80211: multicast to unicast conversion
>   mac80211: cache the only AP_VLAN station
>
>  net/mac80211/cfg.c            |  26 +++++-----
>  net/mac80211/debugfs_netdev.c |  38 ++++++++++++++
>  net/mac80211/ieee80211_i.h    |  61 ++++++++++++++++++++++
>  net/mac80211/rx.c             |   5 +-
>  net/mac80211/sta_info.c       |  41 +++++++++++----
>  net/mac80211/tx.c             | 115 ++++++++++++++++++++++++++++++++++++++++--
>  6 files changed, 258 insertions(+), 28 deletions(-)
>
> --
> 2.1.4
>



-- 
Dave Täht
Let's go make home routers and wifi faster! With better software!
http://blog.cerowrt.org