From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 6EDCA3B25E for ; Mon, 5 Sep 2016 17:29:53 -0400 (EDT) Received: by mail-qk0-x235.google.com with SMTP id z190so200569346qkc.0 for ; Mon, 05 Sep 2016 14:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fZXQzHP/NfBCuLi7AGD+C+UQc2XNstvdFj6hoMlYUwY=; b=Mjbt7QJC2F4bqN8sLQBM9Puto+zyr7G5dfFC80673FtkTR7Mufb1ryY3aUThb3YvVF 62yy1QpsB3/0tpqio6rR2aW+eRQePsQei8UkQ8dMkU8Cebev72At3Vj9XEZ1TQJPgivB 2Du9E+Dmbfe6f4+1Mc6bJIhE7YKVfQL6PF4QpEntgrhVQCUadzODH72VVNngCdeePrvT Z1OVd/F857VQbOa8h47Myh5qDtlwhO87v4mrAmGe05igQft5mwGi96cIqi8jgLYcw/7H vK3JJHFd9YiH6m3YU990wX4whqpsrBcdxj0nXLoicYxeJVgWHY9p4XxsxGcXCV7rxVp9 FZ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fZXQzHP/NfBCuLi7AGD+C+UQc2XNstvdFj6hoMlYUwY=; b=HeUTwnNQc2XQX0uDHJcfcaeubS4r/JEp+8E2J5ZmO2VVpNnfwrchWbGauh+NVbNeyh 5xPpQa0IN8q47ommWaaV+88nmQEySHtCGs5EBDu186GGmu6k/gEUTZmDYjqofjcBUxv1 StGXk5G3mR3BGvaupebVyFLRxxT0GRhTFKtCg7Kc7d5sg1n9fZD5E+cLJuvrZndcaTPu pwjzJmkiHoYUePOnCWsuMLjpG+Y4Zvrkw6YgNO1NIM3PoJRzfFsaqO6CHnkTi28E43OB ct+/1cQkdlqaJ7QZcLPofqeI1SvHIDsimOT3mwbN7zN3GuL7+evEPVBTdT1OcR9tfFRe LT8Q== X-Gm-Message-State: AE9vXwOnIwRiiIesUfofD+qcuOKUETOYIRGI2CVgSnvowkVezLwGToD3u6J78oZH7l5iF8d0fAQ7EmyHGLqDOQ== X-Received: by 10.55.18.40 with SMTP id c40mr28911616qkh.271.1473110993012; Mon, 05 Sep 2016 14:29:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.132.130 with HTTP; Mon, 5 Sep 2016 14:29:52 -0700 (PDT) In-Reply-To: <87d1ki9gzw.fsf@toke.dk> References: <20160902134104.29309-1-toke@toke.dk> <20160905113042.22271-1-toke@toke.dk> <87oa4249hf.fsf@toke.dk> <8760qab6ly.fsf@toke.dk> <87oa429iu3.fsf@toke.dk> <87d1ki9gzw.fsf@toke.dk> From: Dave Taht Date: Mon, 5 Sep 2016 14:29:52 -0700 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Felix Fietkau , make-wifi-fast@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v7] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Sep 2016 21:29:53 -0000 Did a few tests of rrul and rrul_be standalone. Didn't blow it up. Don't know what causes it, it where it is caused. On Mon, Sep 5, 2016 at 2:25 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Dave Taht writes: > >>> Ah, no, those are not panics, those are warnings being triggered by the >>> fast_tx pointer going while the packet was queued. Now, the >>> xmit_fast_finish() function doesn't actually use that for anything othe= r >>> than crypto key configuration, so it would probably be feasible to get >>> rid of that check in the dequeue path. >>> >>> How many of those warnings do you see? >> >> I'm not crazy, I run the rrul test at the conclusion of the run. Which t= his was. >> >> I'll go run it on a fresh boot but... >> >> dmesg | grep 'cut here' >> >> [ 707.011531] ------------[ cut here ]------------ >> [ 707.343296] ------------[ cut here ]------------ >> [ 707.676275] ------------[ cut here ]------------ >> [ 708.009204] ------------[ cut here ]------------ >> [ 708.342138] ------------[ cut here ]------------ >> [ 709.247082] ------------[ cut here ]------------ >> [ 709.580053] ------------[ cut here ]------------ >> [ 709.913023] ------------[ cut here ]------------ >> [ 710.245975] ------------[ cut here ]------------ >> >> Also attached. >> >>> And what do you have to do to get >>> traffic to flow again? >> >> Seems to come back after a while. > > Right. Put up a bunch of new images (the ones with version +3). > Completely untested, but should get rid of the need for the fast_tx > pointer. See if you can blow those up? :) ok. did you wedge the ath10k driver + firmware into there? I'm about to go rewire some things and re-screw in some things... > -Toke --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org