From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x233.google.com (mail-oi0-x233.google.com [IPv6:2607:f8b0:4003:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 306383B260; Mon, 2 May 2016 13:08:10 -0400 (EDT) Received: by mail-oi0-x233.google.com with SMTP id v145so164752013oie.0; Mon, 02 May 2016 10:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=YOW9Nd3OicSTqj6ojfO1mLpZBZpXs4SyY03BVf6YDV4=; b=I7tusD2AfIX+9NwpKg1yzxY8zCdYxt/PR/Hx6Hc9nG9mc9zQ9hbNiBI8m/RCgWtYxa UkxfKbYvZ7qtg7kFFvXGexPwkA2w/YiCC+9imdckZcO5Q0QX9th4Liw8yEuIdk994CNg MCcTuL2+81nmKIfZSHjfBuOoS6+7Pgh60DirlMhxGZLj4vYK66ftvyRNSC3NYwadLrqB 93ZT1Il17MunfsXjtbGyq3Nwf44zY/2uKTvkLenDVYLci6J/g/xgPVIzhp8Co0yrlLkN A/j4VvPZ8I4Nff01Lhu7bgHiN6Qos++jfvoxDWP+FBrLCTVCAXZTQLh4f2z1V6r4hBir Ae5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=YOW9Nd3OicSTqj6ojfO1mLpZBZpXs4SyY03BVf6YDV4=; b=hfh9DPdgexwLnlj+7390EAYHpHU3r59C2N7F3l3wjfEu9HTVC1jx24TT/c9dmqa156 wyFbJRitsQwbn6cq7q0ivo8bW1nol9GEdT9K9tDxcjilvq2Fx+Nx7y6X+aP1S5iBZMn0 yW20stboTA422TMyLIzlGKrTZkjnYNROJiFi/EdH5CsgqzHMQ1VIC/Zm9WTTiqsOTox8 /7m1UrDUpHB92588kzyebhw7GvZy0yDbSrQ6sa1JgwK0xUyt8BAqFo6HbZ7JVwNH33hn zb6Pr/S0uM9U3BZ1du2SOdnVHqObDY4iTMrYPt6TZ3N6rAJ5c0r2fdv/nkPMNwhXMcUz xvAw== X-Gm-Message-State: AOPr4FUbDuH1mQVd3krTAZ2EiGtlNcd7s3yJY5bO3VFeFYrvC756lMjwnvN1ba4Kn7ciJ6/chPfF0bHgo/kVsQ== MIME-Version: 1.0 X-Received: by 10.157.34.14 with SMTP id o14mr16958139ota.63.1462208889592; Mon, 02 May 2016 10:08:09 -0700 (PDT) Received: by 10.202.78.23 with HTTP; Mon, 2 May 2016 10:08:09 -0700 (PDT) In-Reply-To: <1462205669.5535.254.camel@edumazet-glaptop3.roam.corp.google.com> References: <1462125592.5535.194.camel@edumazet-glaptop3.roam.corp.google.com> <865DA393-262D-40B6-A9D3-1B978CD5F6C6@gmail.com> <1462128385.5535.200.camel@edumazet-glaptop3.roam.corp.google.com> <1462136140.5535.219.camel@edumazet-glaptop3.roam.corp.google.com> <1462201620.5535.250.camel@edumazet-glaptop3.roam.corp.google.com> <1462205669.5535.254.camel@edumazet-glaptop3.roam.corp.google.com> Date: Mon, 2 May 2016 10:08:09 -0700 Message-ID: From: Dave Taht To: Eric Dumazet Cc: Roman Yeryomin , Jonathan Morton , make-wifi-fast@lists.bufferbloat.net, "codel@lists.bufferbloat.net" , ath10k , Michal Kazior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [Codel] fq_codel_drop vs a udp flood X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2016 17:08:10 -0000 On Mon, May 2, 2016 at 9:14 AM, Eric Dumazet wrote= : > On Mon, 2016-05-02 at 18:43 +0300, Roman Yeryomin wrote: >> On 2 May 2016 at 18:07, Eric Dumazet wrote: >> > On Mon, 2016-05-02 at 17:18 +0300, Roman Yeryomin wrote: >> > >> >> Imagine you are a video operator, have MacBook Pro, gigabit LAN and >> >> NAS on ethernet side. You would want to get maximum speed. And >> >> fq_codel just dropped it down to 550Mbps for TCP (instead of 750Mbps) >> >> and to 30Mbps for UDP (instead of 900Mbps). >> >> So, again, it looks broken to me. The big regression trying to be addressed here is the decades long increase in wifi overbuffering for slow and normal clients. The number that was making me happy was seeing low speed clients finally have sane behavior: http://blog.cerowrt.org/post/fq_codel_on_ath10k/ I will add your iperf flood test to the testbench. Certainly we don't want to hurt peak speeds overmuch... but we'd also like to see people trying traffic at lower speeds. Incidentally if you are doing openwrt builds that would be of great help. >> > Can you show us your qdisc config ? >> >> Which build do you want? Before it broke or after? Commit hashes for each would help. > > > I want to check your qdisc configuration, the one that you used and > where you had fq_codel performance issues > > tc -s -d qdisc Not sure it's the qdisc version under test here. ? If it is, I'd be perversely happy as for the first time ever the wifi layer started exerting some backpressure on the upper layers of the stack. I'm not sure which parts of which patchset are under test here, either. I saw a few too many patches go by all around, and I am only just this week able to add ath10k to my test matrix. Commit? https://github.com/kazikcz/linux/commits/fqmac-v3.5 has a version of fq_codel in it (and the underlying driver changes) *at the mac80211 layer*, not the qdisc layer. It disables the overlying qdisc. It will need the equivalent new fq_codel_drop logic added to it, that eric just added, also, to do better on the udp flood test. There was a prior branch that did pretty darn well at high speeds, results I put on that blog post I linked to above - 820Mbps for tcp, an actual improvement on the baseline test. The current branch is simpler and did not do as well due in part to not being integrated with rate control (I think). There are pieces dropping in all over, there was a amdsu patch, another patch on rx/tx, --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org