From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x22b.google.com (mail-oi0-x22b.google.com [IPv6:2607:f8b0:4003:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id B3DE63B260; Fri, 6 May 2016 01:51:16 -0400 (EDT) Received: by mail-oi0-x22b.google.com with SMTP id x19so128053429oix.2; Thu, 05 May 2016 22:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=RGxamjX7UQTQFOmfVVel8ry0WrDdmQ0G9jJmikNc/Ns=; b=CeOQjYCYaRLC/VuddNabTpwu/awjo+ScUgxT0UQDioOah6wL2p2z5IDA9ba/HPwhv0 CDFAkvtHSqAaFK8itvONkVhQfPsnadHF+AiSLhAtRJIGsxYal/P9ThKYkBgXkoTPBPlt BZP5VuiJmowFEeWHOm+0jjfBFu1DEK6u7swg7DXVOJsr6Aa0TwKrU0rar5VDjCGeta5J BRHb7JWQG3bNOBGp3BuGrLisj3q+fefhaiqaksTykSEE+42XgSiBplHcUOJIHuKe6Ran g9AmJDnAYSQPcC11da5we5hSk/KFdBxZox2daw+JvxBySLWRKkJZFtgeYabhseMswpI5 6jaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=RGxamjX7UQTQFOmfVVel8ry0WrDdmQ0G9jJmikNc/Ns=; b=B3Nuc+jqMQ9TYj59JqmQRUZgPA8xbhHj4T8CwPi1r2Yor3yhUWjHV+TPYoMMPBAigx 5f3/XA2rp10EDtF19rb5LhpqKNtD/Trfw+UBJliIv/b8d0iQ5XQRAHnaJUvT050zceL4 UdZRbx4njqreejK/bVZru5am/Vu/tOUu8vVbPnUKV6oXjmV3fBLby9mFGYi6NLYLFmHw e+I+mP/XiRFUbRqp4w4yS+9+tGmPn59nQU2hfLdalOGA1oujTc9wjQI+VVZTMb5L9Pq2 asa4X3pS6gaHD9QH67xtEeihQAJxhdl3cFZ//vMxblniHkE52BL3jHMfkZVeJ/8MqtQ0 zryg== X-Gm-Message-State: AOPr4FV2AGd2Xag14Ujn2OWRFeG7fs1k1RC+icLZZCLw+xc+Y8Ew8ZkosNLvQjh15oylrJIzuq9RUSqY8cAWqA== MIME-Version: 1.0 X-Received: by 10.157.4.174 with SMTP id 43mr8196451otm.127.1462513876104; Thu, 05 May 2016 22:51:16 -0700 (PDT) Received: by 10.202.81.76 with HTTP; Thu, 5 May 2016 22:51:16 -0700 (PDT) In-Reply-To: References: <1460636302-31161-1-git-send-email-michal.kazior@tieto.com> <1462446039-1070-1-git-send-email-michal.kazior@tieto.com> <1462446039-1070-6-git-send-email-michal.kazior@tieto.com> Date: Thu, 5 May 2016 22:51:16 -0700 Message-ID: From: Dave Taht To: Michal Kazior Cc: linux-wireless , Johannes Berg , make-wifi-fast@lists.bufferbloat.net, "codel@lists.bufferbloat.net" , Avery Pennarun Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCHv4 5/5] mac80211: add debug knobs for codel X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 05:51:16 -0000 On Thu, May 5, 2016 at 10:27 PM, Michal Kazior wr= ote: > On 5 May 2016 at 17:21, Dave Taht wrote: >> On Thu, May 5, 2016 at 4:00 AM, Michal Kazior = wrote: >>> This adds a few debugfs entries to make it easier >>> to test, debug and experiment. >> >> I might argue in favor of moving all these (inc the fq ones) into >> their own dir, maybe "aqm" or "sqm". >> >> The mixture of read only stats and configuration vars is a bit confusing= . >> >> Also in my testing of the previous patch, actually seeing the stats >> get updated seemed to be highly async or inaccurate. For example, it >> was obvious from the captures themselves that codel_ce_mark-ing was >> happening, but the actual numbers out of wack with the mark seen or >> fq_backlog seen. (I can go back to revisit this) > > That's kind of expected since all of these bits are exposed as > separate debugfs entries/files. To avoid that it'd be necessary to > provide a single debugfs entry/file whose contents are generated on > open() while holding local->fq.lock. But then you could argue it > should contain all per-sta-tid info as well (backlog, flows, drops) as > well instead of having them in netdev*/stations/*/txqs. > Hmm.. I have not had time to write up todays results to any full extent, but they were pretty spectacular. I have a comparison of the baseline ath10k driver vs your 3.5 patchset here on the second plot: http://blog.cerowrt.org/post/predictive_codeling/ The raw data is here: https://github.com/dtaht/blog-cerowrt/tree/master/content/flent/qca-10.2-fq= mac35-codel-5 ... a note: quantum of the mtu (typically 1514) is a saner default than 300, (the older patch I had, set it to 300, dunno what your default is now). and quantum 1514, codel target 5ms rather than 20ms for this test series was *just fine* (but more testing of the lower target is needed) However: quantum "300" only makes sense for very, very low bandwidths (say < 6mbits), in other scenarios it just eats extra cpu (5 passes through the loop to send a big packet) and disables the "new/old" queue feature which helps "push" new flows to flow balance. I'd default it to the larger value. ... In other news, spacex just landed on the barge a few minutes ago. The webcast is still going on https://www.youtube.com/watch?v=3DL0bMeDj76ig and you can reverse it to the landing. :awesome: > > > Micha=C5=82 --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org