From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D7AC23B2A4 for ; Thu, 9 Nov 2017 19:29:04 -0500 (EST) Received: by mail-qk0-x244.google.com with SMTP id x195so10003568qkb.12 for ; Thu, 09 Nov 2017 16:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QXvF74tFl7XghRtyhvCMws60uazSjTQ/SUu3CxfysN8=; b=fJdlTDjqV4j8MOPTI2wxDfUpbUWZ3ZEeY4modGt1S06PKU1jRQXE5MJrhY/IMWO61R PCY/QzhWE+U7CQEyrs9KKyl8njiOBtG2l0Ek24xa+O8jj4oRmAOAKVbjFmrGQtvX79kv dtFBWNjBb7V9EdhEyT/QBhFkjVnUDD8KG8eSOsaOd3jtpaSOlvZNC7hvLZgq4CVQ2grD UGbBdh782m+FeFsUP+KoxL2jxarFTkUty6vLO7P8BX8SDuEjKvy0+2EdzB6YhIsgl9f4 J4/Lr4iaTahfRbyw98QFvg0GvHuc4dcOonP57wjQ6LZ6ECDxEfU2mHKZ/+TvRn6MjuD1 oEhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QXvF74tFl7XghRtyhvCMws60uazSjTQ/SUu3CxfysN8=; b=Xstc/PCr8DXvw0fsfbTBsZh/+puYcrZgxXS6DCL7KO4uOEIsXRpEeago2+xccRHMr1 rLtYDJbPDd22ezqjaAR386KuuR+hn7nCYTB2K/GqYLgGsPv3RIknmr+OUBMsxxvduZFR Txls1d7k+UALPuFWU2U8lGF3PZvlbehsXOu5up4b3CxiUNS7Gt+N77sDNdWCjE0nH3Zf URH1REskBn+A8M2YDfnRhuG8Rlori7Wp1WJ/PGPI6mVsJ/nLXs8nSd0EWk2cq/MydPc6 nlllO8jp2YnPdUzwVjdM2nbqEs7Ox4Cy7re3QMKZpsVsufT6JXA9uvx1LO3y1DGtvcsf 7J/g== X-Gm-Message-State: AJaThX7HPI4Mz6HhPuzxUcuCACJ5vXXkuabSrZIuIzDmT+x3m+vvbPPk Pl1ByJr0X/nqkSoCknOXL4evVWi2GsR75qy2lMc= X-Google-Smtp-Source: AGs4zMYQg66bU9n8UriybcXAkl2MnOIJMnkcWq3mcv6/9xnZwTzUB/AvuSbYoG6ZioD3q+Qw/cCPS08wWt4zSGTH6S8= X-Received: by 10.55.165.129 with SMTP id o123mr3659344qke.8.1510273744461; Thu, 09 Nov 2017 16:29:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.209.200 with HTTP; Thu, 9 Nov 2017 16:29:03 -0800 (PST) In-Reply-To: <87k1yzq9i8.fsf@toke.dk> References: <20171109071945.11033-1-toke@toke.dk> <6112ae948ba2409da27709d01da567eb@NALASEXR01H.na.qualcomm.com> <87k1yzq9i8.fsf@toke.dk> From: Dave Taht Date: Thu, 9 Nov 2017 16:29:03 -0800 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Rajkumar Manoharan , "make-wifi-fast@lists.bufferbloat.net" , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH] ath10k: Re-enable TXQs for all devices X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 00:29:04 -0000 On Thu, Nov 9, 2017 at 4:10 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Rajkumar Manoharan writes: > >>> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the >>> mac80211 TXQs for some devices because of a theoretical throughput >>> regression. We have not seen this regression for a while now, so it sho= uld be >>> safe to re-enable TXQs. >>> >>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>> --- >>> This has been in LEDE trunk for a couple of months now with good result= s. >>> >> Toke, >> >> Good to know that the performance drop is not seen with the chips that d= oes not >> have push-pull support. The issue was originally reported with ap152 + q= ca988x >> by community [1]. Hope this combination is also considered in LEDE. > > Ah, was that the original bug report? Thank you, I have not been able to > find that anywhere! > > The issue that seems to point to has been fixed a while ago; I'll send > and updated patch with a better commit message (also forgot to cc the > ath10k list, I see). > > -Toke Hmm. I remember that thread. I thought we'd basically resolved that issue (45% of the time spent in fq_codel_drop under udp flood), back then, with eric adding the batch drop fix to fq_codel itself: See commit: https://osdn.net/projects/android-x86/scm/git/kernel/commits/9d= 18562a227874289fda8ca5d117d8f503f1dcca which fixed up the problem beautifully: https://lists.bufferbloat.net/pipermail/make-wifi-fast/2016-May/000590.html So if we've been carrying this darn patch for the ath10k vs something that we'd actually fixed elsewhere in the stack, for over a year, sigh. --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619