From: Dave Taht <dave.taht@gmail.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
linux-wireless <linux-wireless@vger.kernel.org>,
make-wifi-fast@lists.bufferbloat.net,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
"Tim Shepard" <shep@alum.mit.edu>
Subject: Re: [Make-wifi-fast] [ath9k-devel] [PATCH 1/2] ath9k: use mac80211 intermediate software queues
Date: Fri, 17 Jun 2016 07:10:17 -0700 [thread overview]
Message-ID: <CAA93jw78dCOsWnsR8ZuGDZJ6PigmZfU3nr-TjhdA0agH6M3OcQ@mail.gmail.com> (raw)
In-Reply-To: <30beabff-a8c6-5431-be09-8f2f83ffc974@nbd.name>
>> struct ath_atx_tid {
>> struct list_head list;
>> + struct sk_buff_head i_q;
> Do we really need a third queue here? Instead of adding yet another
> layer of queueing here, I think we should even get rid of buf_q.
Less queues, more filling!
>
> Channel context based queue handling can be dealt with by
> stopping/starting relevant queues on channel context changes.
what can be done to reduce the impact of channel scans?
http://blog.cerowrt.org/post/disabling_channel_scans/
> buf_q becomes unnecessary when you remove all code in the drv_tx
> codepath that moves frames to the intermediate queue.
>
> Any frame that was pulled from the intermediate queue and prepared for
> tx, but which can't be sent right now can simply be queued to retry_q.
>
> This will also help with getting the diffstat insertion/deletion ratio
> under control ;)
The ideas here can apply elsewhere, also. Are you still actively
working with the mt76?
Anything else "out there" besides that and the ath5k worth looking at?
Am I seeing patches and firmware changes for better statistic keeping
on the ath10k that look promising for airtime fairness... or am I
delusional?
> elsewhere powersave was mentioned
How big can a powersave queue get?
next prev parent reply other threads:[~2016-06-17 14:10 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160617090929.31606-1-toke@toke.dk>
[not found] ` <20160617090929.31606-2-toke@toke.dk>
2016-06-17 13:28 ` [Make-wifi-fast] " Felix Fietkau
2016-06-17 13:43 ` Toke Høiland-Jørgensen
2016-06-17 13:48 ` Felix Fietkau
2016-06-17 16:33 ` Felix Fietkau
2016-06-17 14:10 ` Dave Taht [this message]
2016-06-18 19:05 ` [Make-wifi-fast] [PATCH] ath9k: Switch to using " Toke Høiland-Jørgensen
2016-07-06 16:16 ` [Make-wifi-fast] [PATCH v2] " Toke Høiland-Jørgensen
2016-07-06 17:58 ` Sebastian Gottschall
2016-07-06 18:13 ` Felix Fietkau
2016-07-06 18:52 ` Toke Høiland-Jørgensen
2016-07-06 19:00 ` Felix Fietkau
2016-07-06 19:08 ` Toke Høiland-Jørgensen
2016-07-06 19:34 ` [Make-wifi-fast] [PATCH v3] " Toke Høiland-Jørgensen
2016-07-08 14:27 ` [Make-wifi-fast] [v3] " Kalle Valo
2016-07-08 15:53 ` Toke Høiland-Jørgensen
2016-07-08 16:10 ` Felix Fietkau
2016-07-08 16:28 ` Toke Høiland-Jørgensen
2016-07-08 16:31 ` Felix Fietkau
2016-07-08 16:38 ` Toke Høiland-Jørgensen
2016-07-08 18:24 ` Sebastian Gottschall
2016-07-09 12:00 ` Toke Høiland-Jørgensen
2016-08-05 16:03 ` [Make-wifi-fast] [PATCH v4] " Toke Høiland-Jørgensen
2016-08-22 15:44 ` Kalle Valo
2016-08-22 16:16 ` Toke Høiland-Jørgensen
2016-08-22 17:02 ` Kalle Valo
2016-08-22 17:13 ` Toke Høiland-Jørgensen
2016-08-23 6:59 ` Kalle Valo
2016-08-23 8:52 ` Arend van Spriel
2016-10-05 14:02 ` Toke Høiland-Jørgensen
2016-10-05 15:50 ` Kalle Valo
2016-10-05 16:55 ` Toke Høiland-Jørgensen
2016-10-05 17:54 ` Kalle Valo
2016-10-05 19:56 ` Toke Høiland-Jørgensen
2016-09-02 14:00 ` [Make-wifi-fast] [PATCH v5] " Toke Høiland-Jørgensen
2016-09-03 10:16 ` Felix Fietkau
2016-10-07 11:43 ` [Make-wifi-fast] [v5] " Kalle Valo
2016-11-09 2:22 ` Kalle Valo
2016-11-09 11:31 ` [Make-wifi-fast] [PATCH v6] " Toke Høiland-Jørgensen
2016-11-09 22:42 ` [Make-wifi-fast] [v6] " Kalle Valo
2016-11-09 23:10 ` Toke Høiland-Jørgensen
2016-11-15 15:00 ` Kalle Valo
2016-11-24 13:54 ` [Make-wifi-fast] [PATCH v2] ath9k: Introduce airtime fairness scheduling between stations Toke Høiland-Jørgensen
2016-11-28 10:12 ` [Make-wifi-fast] [PATCH v3] " Toke Høiland-Jørgensen
2016-12-15 8:43 ` [Make-wifi-fast] [v3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA93jw78dCOsWnsR8ZuGDZJ6PigmZfU3nr-TjhdA0agH6M3OcQ@mail.gmail.com \
--to=dave.taht@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=shep@alum.mit.edu \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox