From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x244.google.com (mail-oi0-x244.google.com [IPv6:2607:f8b0:4003:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D108C3B260 for ; Fri, 17 Jun 2016 10:10:18 -0400 (EDT) Received: by mail-oi0-x244.google.com with SMTP id e205so13897090oig.0 for ; Fri, 17 Jun 2016 07:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/T35rFl0TCMWj7ZOtBusLivaHWYd5To2SE2LDP6IdVI=; b=c0YKFE148l+PNDMCUzLgzH4BCrQ1uCbIyNa1pXAMUuuxpnuvJdCeZKj9QHItyXvNv5 IKuDhrbUVlcNHDDebbtEdqG5KULju7o6zdwFJaYXARpEkAkj81MthYXtaddPraPyEKAP /ccoM0YZStBhmWZam3gmYe0kxJgcC0jJ9RvXzl9okvP/puo7FVKsVdPrTGS4eN/ztjww /LE1bcU8IHqXkrxZ1tLomHzGzh3UME/UsODUVeP0whbnRBiusGgzhnm/uiW/NWqTF/dy 82VYsogTVQCZhIUhfoEExG0XJXDoGkolqiWY3KLLpl+e2M0ahI8rXCIgGKoADXUQbuwl 3mrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/T35rFl0TCMWj7ZOtBusLivaHWYd5To2SE2LDP6IdVI=; b=kyYbei7d5hev8Mjp+z4wWqZdHoTQPTLCmX/AQlZFoApsbR65zcZT1U3LNSWNIaTHSG z1oWcgIaxfBf7p4KXOvx39nZ8+PkU4cLcftObKap9H/8gyckNMQKo33YjN4UWBa4gTVX jDuhSBWmivTu9GXVzqTZ69hWqBhI7Um1WhmdSDdw741Pmg6PN2MUcIn+aH1lAIJ9u542 8qXP3KriiNdqx9h5p8recnYSGqzl4gboBA3jVtYxJriGdhxkCxbCinH7UY6ooidt5emK rVrAIaNEwCFtWn9BQOs1+zB74JwfTVV+6R3+IzJ2Oh/2kA1BbZQShO0BBzR7qczUfb17 yklA== X-Gm-Message-State: ALyK8tK3R/0ApsckAUE+70n3xu6NcH6o7d+7zs8oVfZrXqW4MTNcgIuEl4kdQOxvdxUGjs4gDB5WLWYjLz0Sdg== X-Received: by 10.157.26.87 with SMTP id u23mr1506535otu.169.1466172618325; Fri, 17 Jun 2016 07:10:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.175.130 with HTTP; Fri, 17 Jun 2016 07:10:17 -0700 (PDT) In-Reply-To: <30beabff-a8c6-5431-be09-8f2f83ffc974@nbd.name> References: <20160617090929.31606-1-toke@toke.dk> <20160617090929.31606-2-toke@toke.dk> <30beabff-a8c6-5431-be09-8f2f83ffc974@nbd.name> From: Dave Taht Date: Fri, 17 Jun 2016 07:10:17 -0700 Message-ID: To: Felix Fietkau Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , linux-wireless , make-wifi-fast@lists.bufferbloat.net, "ath9k-devel@lists.ath9k.org" , Tim Shepard Content-Type: text/plain; charset=UTF-8 Subject: Re: [Make-wifi-fast] [ath9k-devel] [PATCH 1/2] ath9k: use mac80211 intermediate software queues X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 14:10:18 -0000 >> struct ath_atx_tid { >> struct list_head list; >> + struct sk_buff_head i_q; > Do we really need a third queue here? Instead of adding yet another > layer of queueing here, I think we should even get rid of buf_q. Less queues, more filling! > > Channel context based queue handling can be dealt with by > stopping/starting relevant queues on channel context changes. what can be done to reduce the impact of channel scans? http://blog.cerowrt.org/post/disabling_channel_scans/ > buf_q becomes unnecessary when you remove all code in the drv_tx > codepath that moves frames to the intermediate queue. > > Any frame that was pulled from the intermediate queue and prepared for > tx, but which can't be sent right now can simply be queued to retry_q. > > This will also help with getting the diffstat insertion/deletion ratio > under control ;) The ideas here can apply elsewhere, also. Are you still actively working with the mt76? Anything else "out there" besides that and the ath5k worth looking at? Am I seeing patches and firmware changes for better statistic keeping on the ath10k that look promising for airtime fairness... or am I delusional? > elsewhere powersave was mentioned How big can a powersave queue get?