From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 25A033B260 for ; Sat, 19 Nov 2016 14:42:14 -0500 (EST) Received: by mail-qk0-x235.google.com with SMTP id q130so306136289qke.1 for ; Sat, 19 Nov 2016 11:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=oNZKo0zP27+d6M+Trt28pBNaGZyb3ur4NeqgeXZE5Nc=; b=Xpmf7ovFSAL/Cb33rm/pBEvMnvKYj36InTdmuvdcRLBjtOAGI6yLuBvUIOuwseu6W6 PhS1GnsMJkFflL8xwkNThc3pPQFzO0ecDvLrCw3+FTlyuVXY4VrDbOmZsHnX3TBZy2bf /LilifVt0q8SdmJK/MOnjeWqVcYB+kxhCeMz/n1pnKVSR+I7mFo/Q1X3Xf2b83qRQ35D AcjJg0Vc+1f+jbt4+yk6A3GEkgsGZDAdy/FqmYcf6ywNvPClCA+luG6zDkFFWrNxYH2F p40+88UiBKSe+F+FrPTa/ai54u8olPJBE5W8iVpIDYbeVv10I2z/LnS5ONsaIJ++/dSZ qfMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oNZKo0zP27+d6M+Trt28pBNaGZyb3ur4NeqgeXZE5Nc=; b=QLm4mQMx25Kn/uEsn16GwwWd7gjH9KTLZlmKVsK2+37MbPUil2DHIc3/4DfMcMbYhL oNbQkmx9HZsnwCYU6VAlJ1GT6dPGxqzjjz0FD0dFFRltkvo05J9imLy1tx31GsI2TgPn 7QqDnSVzxjoQW1j5WWCR0FWXhLMIdag9mM7UZ/xvB8Ane/rQ3C3E0UvvogIhLBqiIFul VMUBDP8xkIPMeygUAvkLh95iplV8ONj+DdcpLZysLyGNVJ3WHfOH4k7rKeaXp4tOo0et Aa96S6jJRDxFv54hgH6Gb6vdJfb4W7q4fcVLSi9kHXcoev01hU5aHPQLU75y0ChpA9GQ j4Aw== X-Gm-Message-State: AKaTC01QQVnCgDtzZFnBELlBpAu7+Dq5ij/tkPnNr0xGAc0RU/epspxw041A0hveWttCmP04RFp2uaLVgp/0+w== X-Received: by 10.55.72.86 with SMTP id v83mr7132826qka.262.1479584533707; Sat, 19 Nov 2016 11:42:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.137.198 with HTTP; Sat, 19 Nov 2016 11:42:13 -0800 (PST) In-Reply-To: <87wpfzw9nt.fsf@toke.dk> References: <87wpfzw9nt.fsf@toke.dk> From: Dave Taht Date: Sat, 19 Nov 2016 11:42:13 -0800 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: make-wifi-fast@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] hacking and slashing at the ath9k's retries X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2016 19:42:14 -0000 On Sat, Nov 19, 2016 at 11:29 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Dave Taht writes: > >> I don't see a reason to have ATH_MAX_SW_RETRIES of 30. ? > > Not really no, but in practice it doesn't make much of a difference: > Minstrel will build fairly long retry chains, so before ever getting to > the point where the max of 30 is tested against, a packet can be retried > a dozen times or more... That's next. :) I wanted to fix the !@#@! VI queue first. Am looking over minstrel blues-also. But while I'm hacking and slashing here, I can't think of any reason why we'd ever want a non-aggregate queue depth of > 2. And I think the complete_poll_interval is too long for short packets, but I'm not sure what happens in terms of the jiffies conversion is. -#define ATH_NON_AGGR_MIN_QDEPTH 8 -#define ATH_TX_COMPLETE_POLL_INT 1000 +#define ATH_NON_AGGR_MIN_QDEPTH 3 +#define ATH_TX_COMPLETE_POLL_INT 500 > -Toke --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org