From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x234.google.com (mail-qt0-x234.google.com [IPv6:2607:f8b0:400d:c0d::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 3B9453B2A3 for ; Thu, 2 Feb 2017 19:37:48 -0500 (EST) Received: by mail-qt0-x234.google.com with SMTP id k15so8953173qtg.3 for ; Thu, 02 Feb 2017 16:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=wQQRWcMKnZwtPm5zMBF2GZUNxIO1yAdY8sGM99kjqOo=; b=UxPIhjNxIAWoPVtXVTAYFihuvQdR4kJJzRBx0MyOKaCnw4AVeR/0cxjoSl4KmMZ+Qf j6qPc4favw+mwA1CFgdf0FeV0RRpHqJPHyw3+V/Cb9iUTXeLrSAjUr5PtwBkLDgL1B2d MSG1Yp5mNUvZmNK9eBrzY9y7lGL/i8ASLRFMJM0D8FCdWtujMA9tI9bcOAL528EabjbM j+i9CqUtBvMk3GqZZe3VW/dijP+CZRS6EZSEjojGVkMlww5Zy4zDObVrkg1oKOibI8m9 o4iZzT4dcoNQNyaMWgm0QLJz8fy0LhEVQKJbHqosMqztIIGVvxurIC/1LRPSN2OXbyST vtPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=wQQRWcMKnZwtPm5zMBF2GZUNxIO1yAdY8sGM99kjqOo=; b=Se7oWCN0sfk20T+WvBdEgzuH8u3hhJwoA8fCtH2FiPMNjVn6S2QmgnTItj4XwlGl++ GekwdBFMi3eSm22WQOkJlzImGtkBU4rcrq6AzIIrK3NMW41mSNOPa6nFk+VyZcfr430i iMKi/8xVU8OgR8IemgQit9sio9xZOVVoc9IHTTcea5VjI5sIs7rZY2hTU1sFYgwdzLUr zzvoR8H3aT2zKukpXb6m0jN9DiKpmvzHHv5LeBD4sJw2xkmXWO4fuXdCkSImaeFASkQP ULHGaz7wMFeTnbnEqmEo/NOdcAwjprJr7y87CmaAyUGrn2n399jffLxzKQSl9hkSGvU8 E1uw== X-Gm-Message-State: AMke39l4aJfCZGuQyxvVoiYaicALIqFNycUEC02iditF0Sg/EAOwzN4JywhLslpX6fnRScvvBGrUaUdt+C7VWQ== X-Received: by 10.55.89.196 with SMTP id n187mr10943270qkb.17.1486082267642; Thu, 02 Feb 2017 16:37:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.142.132 with HTTP; Thu, 2 Feb 2017 16:37:47 -0800 (PST) In-Reply-To: References: From: Dave Taht Date: Thu, 2 Feb 2017 16:37:47 -0800 Message-ID: To: make-wifi-fast@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH] killing retries harder, perhaps X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 00:37:48 -0000 Also at one point or another I'd knocked these down to 2 or 3 from 8. No point in servicing a G station to this depth. #define ATH_NON_AGGR_MIN_QDEPTH 8 #define ATH_TX_COMPLETE_POLL_INT 1000 #define ATH_TXFIFO_DEPTH 8 (yea, yea, code freeze in lede, but I've been dying to try this kind of stuff harder after things stablized) On Thu, Feb 2, 2017 at 3:47 PM, Dave Taht wrote: > ATH_TXMAXTRY is now unused. > > ATH_MAX_SW_RETRIES is insanely high by default. > > I finally have some good (well, horrible) data in a consistently noisy > environment and would like to try knocking this down a little in a > future test run. There's smarter ways to do it (like, if you are at > the lowest rate, retry once, higher rates, 4). > > I have tried in the past values as low as 2 for soft retries. > > diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h > b/drivers/net/wireless/ath/ath9k/ath9k.h > index 331947b..304976d 100644 > --- a/drivers/net/wireless/ath/ath9k/ath9k.h > +++ b/drivers/net/wireless/ath/ath9k/ath9k.h > @@ -91,8 +91,7 @@ int ath_descdma_setup(struct ath_softc *sc, struct > ath_descdma *dd, > #define ATH_RXBUF 512 > #define ATH_TXBUF 512 > #define ATH_TXBUF_RESERVE 5 > -#define ATH_TXMAXTRY 13 > -#define ATH_MAX_SW_RETRIES 30 > +#define ATH_MAX_SW_RETRIES 4 > > #define TID_TO_WME_AC(_tid) \ > ((((_tid) =3D=3D 0) || ((_tid) =3D=3D 3)) ? IEEE80211_AC_BE : \ > > > > -- > Dave T=C3=A4ht > Let's go make home routers and wifi faster! With better software! > http://blog.cerowrt.org --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org