From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 48BC53B29E for ; Mon, 7 Oct 2019 15:32:51 -0400 (EDT) Received: by mail-io1-xd2f.google.com with SMTP id a1so31270708ioc.6 for ; Mon, 07 Oct 2019 12:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AplFndiP6Wor9DSrV+Mkw7KBaeUV+n/7DkPYY1jxAvc=; b=lV1J6y0gQ/ipoz6j7koR753AuIsISC6RLe4+r5bMXqpQ8TvU7zg1IlJdUFVzXTFh4o d7fljqSJTlwwx/yaAUcOaUBP0nDjUOagZ8H4RTzynA1XROWMzpaEKhtnzF2MQyK1STJc LzboEtROg8EzobsOMpqwrXTY4qQW/eBNrxK1OTwkjPk3DXi4i38g4Sq7zA1EazuiWnRd kYUJoLZTjRbuJorx4B0Xo0kne2UrumPw08nRxM1/9OJ7mcThi9t3cuIWu6Dt7+Bqohjf tlI6ngIdXJEmFR40O9JI3k1uJl3JTnVmNidAue989WKHOXSi8ms6X9OW1o6hHNA447jk HeFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AplFndiP6Wor9DSrV+Mkw7KBaeUV+n/7DkPYY1jxAvc=; b=Qvj/5ni/ml1ndTfpuI9Bwe3R+iF11Knm3mbNLHqa39sLMwhlK5ftncbjA+3loVlBJT AZXyC8eLG25bcKaUiNgY5y/w6SgWzZyVRSUD3Bgcwzux/MUyzgUgXPr7ADu1B+b+oyHk OOSO2i6AbBq6gt/bOFGKoLN01czi2+a76RX6MIm6moO8MfGi1fBgahyCGZB7zhYBCovW 9kOoqG+6q3e4GotF6Jwn/qDoMr/ErKSnYd1JRQGPi7e/DGnFKcbZk1YbkMZfenkBLQQB QD42z/0Xb5HoYW737a0rg8mHaIB5OT40UnRsdUbr6J/J7YIIwsM9W5eZBlQoF464H1q6 p8Ng== X-Gm-Message-State: APjAAAXrXPRFltcUcblxqEh/gpPq6mOs5KqEbkHGujmsfHldj9HX2+31 FnSFYQQeTDJ9Uk1M7yWbf+czb25Tq/a2vEmX2I8= X-Google-Smtp-Source: APXvYqxeUJO7jGUAnHP1hoXWKhQRcJTfY/NPg/q44O2OfICk9GCqD4Yhg/6hq8XqPyP/PvoP6f9Vkrwma63cKn4p4aM= X-Received: by 2002:a05:6638:6b2:: with SMTP id d18mr13112917jad.61.1570476770526; Mon, 07 Oct 2019 12:32:50 -0700 (PDT) MIME-Version: 1.0 References: <20191004062151.131405-1-kyan@google.com> <20191004062151.131405-2-kyan@google.com> <87imp4o6qp.fsf@toke.dk> <87pnj9n55y.fsf@toke.dk> In-Reply-To: From: Dave Taht Date: Mon, 7 Oct 2019 12:32:39 -0700 Message-ID: To: Johannes Berg Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Kan Yan , Make-Wifi-fast , Yibo Zhao , linux-wireless , Felix Fietkau Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH 1/2] mac80211: Implement Airtime-based Queue Limit (AQL) X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Oct 2019 19:32:51 -0000 On Mon, Oct 7, 2019 at 12:23 PM Johannes Berg w= rote: > > On Sun, 2019-10-06 at 19:40 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : > > > > That's a good point. I haven't thought about real simultaneous dual > > > band chipset and such chipset do exists now. Is RSDB support coming t= o > > > mac80211 soon? Just curious if it will be just virtual interfaces or > > > something else. I chose "local" instead of "sdata" thinking about the > > > case of several virtual interfaces (AP, STA, MESH) operates in the > > > same channel, then the interface total could be a better choice. > > > > > > I am ok with moving the "aql_total_pending_airtime" into sdata, but > > > afraid that's not the most optimal choice for the case of multiple > > > virtual interfaces operates in the same channel. > > > Maybe we could leave it in "local" for now. What do you think? > > > > I'd lean towards keeping it in 'local' for consistency with all the > > other airtime stuff. For now, I think having multiple SSIDs on the same > > radio is more common than the reverse (multiple bands on a single > > radio). > > > > In particular, the per-group airtime fairness stuff is definitely > > designed on the assumption that all BSSes share the same band. > > s/band/channel/, presumably. > > > So if and when we start supporting true multi-band devices we'll have t= o > > change these things anyway. So might as well keep everything together s= o > > it all gets fixed :) > > I guess I'm OK with that, but I'm pretty sure this will come up sooner > rather than later ... > > What else is there though? World domination! > > johannes > > _______________________________________________ > Make-wifi-fast mailing list > Make-wifi-fast@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/make-wifi-fast --=20 Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-205-9740