From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E0F8F3B25D for ; Sun, 5 Jun 2016 22:26:29 -0400 (EDT) Received: by mail-it0-x234.google.com with SMTP id z189so32015880itg.0 for ; Sun, 05 Jun 2016 19:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/2y07RpCoOlSQtfz+fsvjTRSQ1uBjwi0EWhdGuFTYHE=; b=emNAl4LdgvsNzsOUFyG5eO7o+Qb5DxwuP2viBYYv0VvKN28AVtIKihsNataE5uS7ee Cpj+lmMEi036VwIrX82WKu2UPqngzZoLyLGEbL/RY4jCE6eoTp6XU6FONmBZ96Bw/6rF 2w78v3YCSUByUTK9/Fv0i9NjmeXiXDIvJZ1c0OC9C2NSyCh8MtdS/rAL0A+4xSldC5I3 cOMSJijhPwWi0ncFYx6A3iO7ukrZ3SIQALpYRQZREpcYn4jyPzfsrK+MpopEd96IDPKw j6yPjKCcjmpiQnX/XHcWUCq+zUotF9uk4hFwvvyjdPvj288XIF5N6DR9MK0oRoXnr3kD 9Iww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/2y07RpCoOlSQtfz+fsvjTRSQ1uBjwi0EWhdGuFTYHE=; b=Hr2UaLE9nSVcA7uM8+UoDN2RRjehQJc1xsvBaOhQcJzy46NEcYu9d8vTtFCbICvayr hKvPUFlpXTUVWYtHTL6oHJnzlR32QwQa27FQTuM61zG64sk3jK97vkJDXfPK+MudC3/Q RlvMVxGW8Qx/UZpInsq//CQiPJYvzoJgKhkEF4+l76TZ8wPyk3FoeJvaYrbpAC5X7ptE IN6UqToqRetRBZsuVrVOCeInv9Cl2+3Rv1sm80JlvgejLp/olA83+F9TTpaN0NjUTUi1 1DoGs+ZwK/LQcixeNgpp1hTfgcnnuOuIHiObhE76OT3jhRAbx5LZV1t+tF6LgmG9652i vqDA== X-Gm-Message-State: ALyK8tLaseXpcy/7a8GA/UbT1wDc5ERF7W/NAsHaPtvzOTSS77x+7tzbUpGu/o0uHIvafepgNA2A2Y5y/yVOGg== X-Received: by 10.36.79.150 with SMTP id c144mr13588646itb.2.1465179989199; Sun, 05 Jun 2016 19:26:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.165.205 with HTTP; Sun, 5 Jun 2016 19:26:09 -0700 (PDT) In-Reply-To: <20160603165144.17356-2-toke@toke.dk> References: <20160603165144.17356-1-toke@toke.dk> <20160603165144.17356-2-toke@toke.dk> From: Julian Calaby Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: linux-wireless , make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org, Michal Kazior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 28 Nov 2016 08:47:10 -0500 Subject: Re: [Make-wifi-fast] [RFC/RFT 1/5] mac80211: skip netdev queue control with software queuing X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Mon, 06 Jun 2016 02:26:30 -0000 X-Original-Date: Mon, 6 Jun 2016 12:26:09 +1000 X-List-Received-Date: Mon, 06 Jun 2016 02:26:30 -0000 Hi Toke, On Sat, Jun 4, 2016 at 2:51 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > From: Michal Kazior > > Qdiscs are designed with no regard to 802.11 > aggregation requirements and hand out > packet-by-packet with no guarantee they are > destined to the same tid. This does more bad than > good no matter how fairly a given qdisc may behave > on an ethernet interface. > > Software queuing used per-AC netdev subqueue > congestion control whenever a global AC limit was > hit. This meant in practice a single station or > tid queue could starve others rather easily. This > could resonate with qdiscs in a bad way or could > just end up with poor aggregation performance. > Increasing the AC limit would increase induced > latency which is also bad. > > Disabling qdiscs by default and performing > taildrop instead of netdev subqueue congestion > control on the other hand makes it possible for > tid queues to fill up "in the meantime" while > preventing stations starving each other. > > This increases aggregation opportunities and > should allow software queuing based drivers > achieve better performance by utilizing airtime > more efficiently with big aggregates. > > Signed-off-by: Michal Kazior As this patch is passing through your hands, you need to add your Signed-off-by too. Thanks, --=20 Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/