From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-x22f.google.com (mail-ua0-x22f.google.com [IPv6:2607:f8b0:400c:c08::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E4E1F3B2A3 for ; Wed, 18 Jan 2017 12:38:46 -0500 (EST) Received: by mail-ua0-x22f.google.com with SMTP id y9so14863733uae.2 for ; Wed, 18 Jan 2017 09:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=Iqc9ldXUG7y4Qv08zaW+yJFIHtaggKAhd7qoYc7U3/Y=; b=YaR8vKbF2X4/ZtSOwtQlrZbARSrWXL4DgPIrXJCY1nwGXOkK5zpRCnxSa6J9r8icKB jbKpROcYLR+5XbxyxhteitaT6nC1HOfOzXQgnNXAtmOki+374+3RrGTPBINiGFHM2Jcw l0s0OHLm2yjyNcm/5EIRycN5xV5L5m7ObQq2OoTItarqYfh1XO4Q2W2Vs9krA837Zrnp 0y67nBIEYFcHqJuOGEsIHHwG8NKmvJk2XAsJcno9gx9oiiDSP1Zw+WR1FHdE3VDt2WwE mzG1xki9FXFFzEfn3YBfyYOQ/WIcidUm2IG6j3Me2qUhshHKCCJzzF+lCAOE8OwHQVP5 ayRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=Iqc9ldXUG7y4Qv08zaW+yJFIHtaggKAhd7qoYc7U3/Y=; b=UGac7Zz9akNu77r74KztpErCcYBhGZOyZ1IC7EpIhVs+B/zzUz3d0GwcHfTO9LnBwi ArqMIWefSHA1jtf8DF3giIVKLd7mX3PRVoIvWeAPFm6wCmcIF2r7UrDzMAvquoPWMRPi w7e9W7wum3F52l458Lu4YXFX3+PdzADst4sTKL81aFT/BiHB4iLsWhmg+UQ3/fUiB0e2 Z81S2wi0PGVSHtmpjB/s5AayHhK3VLwgX4mkScLLfTp5150r5vt/jImo0a2uYaCDZE8w ui/NRkO2K9DTTrlPFZDwrYNOt8ge6y/kqy/DDatqiEi5KfOsHZoz5UWckL6B/4vU7OY3 U75w== X-Gm-Message-State: AIkVDXL08pEbrMYJwfCQSKwDsvVu8Q9KmAnwxSsWniOpL9l/uGqZmELC5fyh2K5BJW0OKCYsa/cMYjwfjdFbNA== X-Received: by 10.176.17.18 with SMTP id e18mr2028168uab.112.1484761126315; Wed, 18 Jan 2017 09:38:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.31.59.5 with HTTP; Wed, 18 Jan 2017 09:38:45 -0800 (PST) Received: by 10.31.59.5 with HTTP; Wed, 18 Jan 2017 09:38:45 -0800 (PST) In-Reply-To: References: From: Jon Pike Date: Wed, 18 Jan 2017 09:38:45 -0800 Message-ID: To: make-wifi-fast@lists.bufferbloat.net Content-Type: multipart/alternative; boundary=f403045e3b6e82ac03054661e346 Subject: Re: [Make-wifi-fast] Fwd: [PATCH] mac80211: prevent skb/txq mismatch X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 17:38:47 -0000 --f403045e3b6e82ac03054661e346 Content-Type: text/plain; charset=UTF-8 And, it is probably worth mentioning that I also have IPV6 routing disabled, after what seemed like an issue with a local device being overly chatty. Have also reread a bit, and see that Jan 3 or 4 seems to be the date of ATF removal, so I assume I still have it. On Jan 18, 2017 9:00 AM, wrote: Send Make-wifi-fast mailing list submissions to make-wifi-fast@lists.bufferbloat.net To subscribe or unsubscribe via the World Wide Web, visit https://lists.bufferbloat.net/listinfo/make-wifi-fast or, via email, send a message with subject or body 'help' to make-wifi-fast-request@lists.bufferbloat.net You can reach the person managing the list at make-wifi-fast-owner@lists.bufferbloat.net When replying, please edit your Subject line so it is more specific than "Re: Contents of Make-wifi-fast digest..." Today's Topics: 1. Re: Fwd: [PATCH] mac80211: prevent skb/txq mismatch (Jon Pike) ---------- Forwarded message ---------- From: Jon Pike To: make-wifi-fast@lists.bufferbloat.net Cc: Date: Tue, 17 Jan 2017 22:58:30 -0800 Subject: Re: [Make-wifi-fast] Fwd: [PATCH] mac80211: prevent skb/txq mismatch I'm pretty clueless on this, but as a single data point, my Archer C7 has abt 21 days of uptime now, since my last update, as the single router in a 4 person household. I've been running cake/piece of cake the whole time. Standard disclaimers apply as to clueless user not knowing if his FW version has anything to do with the issue in question, or if its connected to other things like whatever is going on with the airtime fairness. But the comment in the third paragraph sounded interesting in light of my lack of a crash and running a SQM method, FWIW. My last update was a sysupgrade to LEDE Reboot SNAPSHOT r2687-dc5f496 pretty sure date was 12-27-16. Today's Topics: 1. Fwd: [PATCH] mac80211: prevent skb/txq mismatch (Dave Taht) ---------- Forwarded message ---------- From: Dave Taht To: make-wifi-fast@lists.bufferbloat.net Cc: Date: Thu, 12 Jan 2017 10:44:12 -0800 Subject: [Make-wifi-fast] Fwd: [PATCH] mac80211: prevent skb/txq mismatch yea! (I think) ---------- Forwarded message ---------- From: Michal Kazior Date: Thu, Jan 12, 2017 at 6:28 AM Subject: [PATCH] mac80211: prevent skb/txq mismatch To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, greearb@candelatech.com, mohammed@qti.qualcomm.com, Michal Kazior Station structure is considered as not uploaded (to driver) until drv_sta_state() finishes. This call is however done after the structure is attached to mac80211 internal lists and hashes. This means mac80211 can lookup (and use) station structure before it is uploaded to a driver. If this happens (structure exists, but sta->uploaded is false) fast_tx path can still be taken. Deep in the fastpath call the sta->uploaded is checked against to derive "pubsta" argument for ieee80211_get_txq(). If sta->uploaded is false (and sta is actually non-NULL) ieee80211_get_txq() effectively downgraded to vif->txq. At first glance this may look innocent but coerces mac80211 into a state that is almost guaranteed (codel may drop offending skb) to crash because a station-oriented skb gets queued up on vif-oriented txq. The ieee80211_tx_dequeue() ends up looking at info->control.flags and tries to use txq->sta which in the fail case is NULL. .......... _______________________________________________ Make-wifi-fast mailing list Make-wifi-fast@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/make-wifi-fast _______________________________________________ Make-wifi-fast mailing list Make-wifi-fast@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/make-wifi-fast --f403045e3b6e82ac03054661e346 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
And, =C2=A0it is p= robably worth mentioning that I also have IPV6 routing disabled, after what= seemed like an issue with a local device being overly chatty.=C2=A0=

<= div dir=3D"auto">Have also reread a = bit, =C2=A0and see that Jan 3 or 4 seems to be the date of ATF removal, so = I assume I still have it.

=
On Jan 18, 2017 9:00 AM, <make-wifi-fast-request@lists.= bufferbloat.net> wrote:
Send Make-wifi-fast mailing list submissions to
=C2=A0 =C2=A0 =C2=A0 =C2=A0 make-wifi-fast@lists.bufferbloat.net

To subscribe or unsubscribe via the World Wide Web, visit
=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://lists.buffe= rbloat.net/listinfo/make-wifi-fast
or, via email, send a message with subject or body 'help' to
=C2=A0 =C2=A0 =C2=A0 =C2=A0 make-wifi-fast-request@lists.bufferbloat.net

You can reach the person managing the list at
=C2=A0 =C2=A0 =C2=A0 =C2=A0 make-wifi-fast-owner@lists.bufferbloat.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Make-wifi-fast digest..."

Today's Topics:

=C2=A0 =C2=A01. Re: Fwd: [PATCH] mac80211: prevent skb/txq mismatch (Jon Pi= ke)


---------- Forwarded message ----------
From:=C2=A0Jon Pike <= jonpike54@gmail.com>
To:= =C2=A0make-wifi-fas= t@lists.bufferbloat.net
Cc:=C2=A0
Date:=C2=A0Tue, 17 Jan 2017 22:= 58:30 -0800
Subject:=C2=A0Re: [Make-wifi-fast] Fwd: [PATCH] mac80211: pr= event skb/txq mismatch
I'm pretty clueless on this= , =C2=A0but as a single data point, my Archer C7 has abt 21 days of uptime = now, since my last update, as the single router in a 4 person household.=C2= =A0 I've been running cake/piece of cake the whole time.

Standard disclaimers apply as to clueless us= er not knowing if his FW version has anything to do with the issue in quest= ion, or if its connected to other things like whatever is going on with the= airtime fairness.=C2=A0 But the comment in the third paragraph sounded int= eresting in light of my lack of a crash and running a SQM method, FWIW.

My last updat= e was a sysupgrade to LEDE Reboot SNAPSHOT r2687-dc5f496 pretty sure date w= as 12-27-16.


Today's Topics:

=C2=A0 =C2=A01. Fwd: [PATCH] mac80211: prevent skb/txq mismatch (Dave Taht)=


---------- Forwarded message ----------
From:=C2=A0Dave Taht <= ;dave.taht@gmail.c= om>
To:=C2=A0make-wifi-fast@lists.bufferbloat.net
Cc:= =C2=A0
Date:=C2=A0Thu, 12 Jan 2017 10:44:12 -0800
Subject:=C2=A0[Make= -wifi-fast] Fwd: [PATCH] mac80211: prevent skb/txq mismatch
yea! (I thin= k)


---------- Forwarded message ----------
From: Michal Kazior <michal.kazior@tieto.com>
Date: Thu, Jan 12, 2017 at 6:28 AM
Subject: [PATCH] mac80211: prevent skb/txq mismatch
To: johannes= @sipsolutions.net
Cc: lin= ux-wireless@vger.kernel.org, greearb@candelatech.com,
mohammed@qti= .qualcomm.com, Michal Kazior <michal.kazior@tieto.com>


Station structure is considered as not uploaded
(to driver) until drv_sta_state() finishes. This
call is however done after the structure is
attached to mac80211 internal lists and hashes.
This means mac80211 can lookup (and use) station
structure before it is uploaded to a driver.

If this happens (structure exists, but
sta->uploaded is false) fast_tx path can still be
taken. Deep in the fastpath call the sta->uploaded
is checked against to derive "pubsta" argument for
ieee80211_get_txq(). If sta->uploaded is false
(and sta is actually non-NULL) ieee80211_get_txq()
effectively downgraded to vif->txq.

At first glance this may look innocent but coerces
mac80211 into a state that is almost guaranteed
(codel may drop offending skb) to crash because a
station-oriented skb gets queued up on
vif-oriented txq. The ieee80211_tx_dequeue() ends
up looking at info->control.flags and tries to use
txq->sta which in the fail case is NULL.
..........

_______________________________________________
Make-wifi-fast mailing list
M= ake-wifi-fast@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/mak= e-wifi-fast


_______________________________________________
Make-wifi-fast mailing list
Make-wifi-fast@list= s.bufferbloat.net
https://lists.bufferbloat.net/listinfo/mak= e-wifi-fast

--f403045e3b6e82ac03054661e346--