From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa41.google.com (mail-vk1-xa41.google.com [IPv6:2607:f8b0:4864:20::a41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 8E9953B29D for ; Thu, 27 Feb 2020 04:26:01 -0500 (EST) Received: by mail-vk1-xa41.google.com with SMTP id g7so527292vkl.12 for ; Thu, 27 Feb 2020 01:26:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XKhO1AQ00NQAb2mxlmISdfwyHlX7vjWtP3qsga5GwBM=; b=vXS4LjAiJ4ELHEh0mx10EpqmGWL50wYXysbYgFM+seolegvNnlf5VJqjAoEKOUsvFW g17Y+FeGDY4QEdlF6PX+PaPR8ITq4lBCgFq8HK7duF4qLDT+yoXc8seyiBcUR5G6j2pD 5Tjus1dZRJ4eMJJlMQdVlmik+/GYDMxON8suKoZfE+dqwii+R/v9eKhZC9RruGLOsoCW cSkPM+TX+x9Pfz97h8ZKdXixr+iciwtrlBpMpoJ4SMB6xyyhBoCPozJcJBD6uSJEDEye XN1c5cr26sozJ5DbiYr+lxvGuLyma6R5yIIPT7+cesZmnV/cqYDr0X8Kr4gbgoh9SKov P6pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XKhO1AQ00NQAb2mxlmISdfwyHlX7vjWtP3qsga5GwBM=; b=DtEb05QCF3UdbAy0Rt11O2zDHK44TaP6K33WDFdxUm22eAKAVLLlrQucSYowuMKgAT E6KDOX4yc9Wy8LgdhfAwahDl3xte81zJOrFCAZj/r8ZhFA3n3Cjq2BnSOelEyFIZos6J XgNk2NypRDC7U9CDDo8XLDYN8fYbxeSLsI//FJzkle/2LqYBAq5ZWAJZJhWdZGtN/d5R rw7x1P2CEWMLlQK7odlBpHFq0uN3tkl7a1Qzir/AomU3Cf+TaQ9/ebAGfxRZLiRlzppe cFoi7GCsWxQEA1SHk+lPvgGJXoJgWK9aDMzI6/WU0gJzlc2YkbzNTMYDYtyLDYqfMXmE 45Xw== X-Gm-Message-State: APjAAAXqgO3q7P1a3ziWny37RPXrC633oErDfYyCSAeJNpmqVd6EPP22 Mb2rkVge0JuDLO+/Jf4tZWkj5Yc+mHzyEvVriwM= X-Google-Smtp-Source: APXvYqwY+o2PgZpq0I8t22A/4AUUHc81pvfiagrPCAYKch0tsrlsBLxiPNwwpiA0Ygx+eqlwBwwzb6M/3tfbf1YWCjA= X-Received: by 2002:a1f:b6d7:: with SMTP id g206mr2114238vkf.8.1582795560965; Thu, 27 Feb 2020 01:26:00 -0800 (PST) MIME-Version: 1.0 References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-5-kyan@google.com> In-Reply-To: <20191119060610.76681-5-kyan@google.com> From: Justin Capella Date: Thu, 27 Feb 2020 01:25:50 -0800 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Johannes Berg , linux-wireless , make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name, Yibo Zhao , John Crispin , lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com, Kan Yan Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Thu, 27 Feb 2020 04:56:25 -0500 Subject: Re: [Make-wifi-fast] [PATCH v11 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 09:26:01 -0000 > ieee80211_report_used_skb(). As an optimisation, we also subtract the > airtime on regular TX completion, zeroing out the value stored in the > packet afterwards, to avoid having to do an expensive lookup of the station > from the packet data on every packet. > > This patch does *not* include any mechanism to wake a throttled TXQ again, > on the assumption that this will happen anyway as a side effect of whatever > freed the skb (most commonly a TX completion). I recall a recent patch for ath10k sdio that disabled tx acknowledgement for performance gains and am wondering if that will be problematic? Presumably not since it would be caught at the dequeue, but thought I'd ask-- wondering what the effect of failed tx's or block acknowledgement is on this stuff I'll need to study the code some more https://lore.kernel.org/linux-wireless/0101016eb1903db0-ef7063b4-0f42-4a01-8886-327541e6c1a4-000000@us-west-2.amazonses.com/T/#t