Lets make wifi fast again!
 help / color / mirror / Atom feed
From: Michael Yartys <michael.yartys@protonmail.com>
To: Michael Yartys via Make-wifi-fast <make-wifi-fast@lists.bufferbloat.net>
Subject: [Make-wifi-fast] AQL patch
Date: Sun, 24 Jan 2021 19:48:40 +0000	[thread overview]
Message-ID: <XNDuTmF-6ZV1pt_k1AamjXCx0eyYPx6_Bf87i4TovFZwUvCRIP6bUsVFIrAbNxqOAxjkipPUaAV4I9bateJmOq6QB-3CeAsYtr2o3UKcADo=@protonmail.com> (raw)

Hi, Dave

A couple of days back you talked about wanting to send in a patch to OpenWrt to lower the CoDel target in AQL to 10 ms. I was thinking about taking a shot at doing it myself, and I was looking at the patch you provided in the AQL discussion thread on the OpenWrt forum for some pointers: https://forum.openwrt.org/t/aql-and-the-ath10k-is-lovely/59002/80

I'm having some questions about the following part:

-       if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {
-               sta->cparams.target = MS2TIME(50);
-               sta->cparams.interval = MS2TIME(300);
-               sta->cparams.ecn = false;
-       } else {
-               sta->cparams.target = MS2TIME(20);
-               sta->cparams.interval = MS2TIME(100);
-               sta->cparams.ecn = true;
-       }
+       sta->cparams.target = MS2TIME(5);
+       sta->cparams.interval = MS2TIME(100);
+       sta->cparams.ecn = true;

So in this part the code has a different target and interval when the throughput is low than when it's high. In addition ECN is disabled at low rates. You patch simply removes this in favour of keeping ECN on and having a set target and interval regardless of rate. Is this the right way of doing it, or should a patch ideally keep the rate dependent logic but change the targets and intervals? In that case we should probably do some more testing and tuning to figure out the right values.

Michael

             reply	other threads:[~2021-01-24 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-24 19:48 Michael Yartys [this message]
2021-01-24 19:58 ` Dave Taht
2021-01-24 20:43   ` Michael Yartys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='XNDuTmF-6ZV1pt_k1AamjXCx0eyYPx6_Bf87i4TovFZwUvCRIP6bUsVFIrAbNxqOAxjkipPUaAV4I9bateJmOq6QB-3CeAsYtr2o3UKcADo=@protonmail.com' \
    --to=michael.yartys@protonmail.com \
    --cc=make-wifi-fast@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox