From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.yartys@protonmail.com>
Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch
 [185.70.40.133])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 4406D3B2A4
 for <make-wifi-fast@lists.bufferbloat.net>;
 Sun, 24 Jan 2021 14:48:57 -0500 (EST)
Date: Sun, 24 Jan 2021 19:48:40 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail; t=1611517735;
 bh=3YbKkdkmyhLouVTVNyjSVuUz21pdNMlLKlze/QesWrg=;
 h=Date:To:From:Reply-To:Subject:From;
 b=XlObqKFlM3VQwgMQ1Rnwp9nhcrDDXYzTlCmUP814W9IM2gI2g554ALpyiqcnw1uBE
 Bolg9nirZVsrs1Hy2eCCstr1O+8tKZ1MdBTXMXAeh3PNPK+kIP+76IzBhfNT7CRV6q
 9fE/HNXFCyr/up5b6vQLlaj7uiEBXgTgXLAshFMs=
To: Michael Yartys via Make-wifi-fast <make-wifi-fast@lists.bufferbloat.net>
From: Michael Yartys <michael.yartys@protonmail.com>
Reply-To: Michael Yartys <michael.yartys@protonmail.com>
Message-ID: <XNDuTmF-6ZV1pt_k1AamjXCx0eyYPx6_Bf87i4TovFZwUvCRIP6bUsVFIrAbNxqOAxjkipPUaAV4I9bateJmOq6QB-3CeAsYtr2o3UKcADo=@protonmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no
 autolearn=disabled version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 mailout.protonmail.ch
Subject: [Make-wifi-fast] AQL patch
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sun, 24 Jan 2021 19:48:57 -0000

Hi, Dave

A couple of days back you talked about wanting to send in a patch to OpenWr=
t to lower the CoDel target in AQL to 10 ms. I was thinking about taking a =
shot at doing it myself, and I was looking at the patch you provided in the=
 AQL discussion thread on the OpenWrt forum for some pointers: https://foru=
m.openwrt.org/t/aql-and-the-ath10k-is-lovely/59002/80

I'm having some questions about the following part:

-       if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {
-               sta->cparams.target =3D MS2TIME(50);
-               sta->cparams.interval =3D MS2TIME(300);
-               sta->cparams.ecn =3D false;
-       } else {
-               sta->cparams.target =3D MS2TIME(20);
-               sta->cparams.interval =3D MS2TIME(100);
-               sta->cparams.ecn =3D true;
-       }
+       sta->cparams.target =3D MS2TIME(5);
+       sta->cparams.interval =3D MS2TIME(100);
+       sta->cparams.ecn =3D true;

So in this part the code has a different target and interval when the throu=
ghput is low than when it's high. In addition ECN is disabled at low rates.=
 You patch simply removes this in favour of keeping ECN on and having a set=
 target and interval regardless of rate. Is this the right way of doing it,=
 or should a patch ideally keep the rate dependent logic but change the tar=
gets and intervals? In that case we should probably do some more testing an=
d tuning to figure out the right values.

Michael