From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>, "Kan Yan" <kyan@google.com>
Cc: linux-wireless@vger.kernel.org,
make-wifi-fast@lists.bufferbloat.net,
Felix Fietkau <nbd@nbd.name>, Yibo Zhao <yiboz@codeaurora.org>
Subject: Re: [Make-wifi-fast] [PATCH 1/2] mac80211: Implement Airtime-based Queue Limit (AQL)
Date: Mon, 07 Oct 2019 21:23:49 +0200 [thread overview]
Message-ID: <aa40e945adfbeb52890afb2de493142e82ecf69d.camel@sipsolutions.net> (raw)
In-Reply-To: <87pnj9n55y.fsf@toke.dk>
On Sun, 2019-10-06 at 19:40 +0200, Toke Høiland-Jørgensen wrote:
> > That's a good point. I haven't thought about real simultaneous dual
> > band chipset and such chipset do exists now. Is RSDB support coming to
> > mac80211 soon? Just curious if it will be just virtual interfaces or
> > something else. I chose "local" instead of "sdata" thinking about the
> > case of several virtual interfaces (AP, STA, MESH) operates in the
> > same channel, then the interface total could be a better choice.
> >
> > I am ok with moving the "aql_total_pending_airtime" into sdata, but
> > afraid that's not the most optimal choice for the case of multiple
> > virtual interfaces operates in the same channel.
> > Maybe we could leave it in "local" for now. What do you think?
>
> I'd lean towards keeping it in 'local' for consistency with all the
> other airtime stuff. For now, I think having multiple SSIDs on the same
> radio is more common than the reverse (multiple bands on a single
> radio).
>
> In particular, the per-group airtime fairness stuff is definitely
> designed on the assumption that all BSSes share the same band.
s/band/channel/, presumably.
> So if and when we start supporting true multi-band devices we'll have to
> change these things anyway. So might as well keep everything together so
> it all gets fixed :)
I guess I'm OK with that, but I'm pretty sure this will come up sooner
rather than later ...
What else is there though?
johannes
next prev parent reply other threads:[~2019-10-07 19:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 6:21 [Make-wifi-fast] [PATCH 0/2] " Kan Yan
2019-10-04 6:21 ` [Make-wifi-fast] [PATCH 1/2] mac80211: " Kan Yan
2019-10-04 12:30 ` Johannes Berg
2019-10-04 12:34 ` Johannes Berg
2019-10-04 15:44 ` Toke Høiland-Jørgensen
2019-10-05 2:08 ` Kan Yan
2019-10-05 2:19 ` Kan Yan
2019-10-06 17:40 ` Toke Høiland-Jørgensen
2019-10-07 19:23 ` Johannes Berg [this message]
2019-10-07 19:32 ` Dave Taht
2019-10-07 19:40 ` Toke Høiland-Jørgensen
2019-10-07 19:43 ` Johannes Berg
2019-10-10 2:35 ` Kan Yan
2019-10-04 6:21 ` [Make-wifi-fast] [PATCH 2/2] ath10k: Enable " Kan Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa40e945adfbeb52890afb2de493142e82ecf69d.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=toke@redhat.com \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox