From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine01.qualcomm.com (wolverine01.qualcomm.com [199.106.114.254]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 617453B25D for ; Fri, 8 Jul 2016 10:27:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1467988066; x=1499524066; h=mime-version:content-transfer-encoding:subject:from: in-reply-to:to:cc:message-id:date; bh=m7DECSGbVaZ8HBYV82LJ2W4ba8pRVmlzwwt7Xt2yRCk=; b=m4P9eKCh20rQ6Mx3P3Pd9ZUC0zBNG7QzS/O+dPn3ZNzVkIw1KM0ejPC0 mUdETlFrPkR8jE23jMl/LswXmWmnNlBi7fzTS2OrMWRRNCZQKGklQyRSY miSjnGEstR1XlondAN5LtgF9Vso5fXdavEodUbifLeKOzy0Ufuqij3bMZ I=; X-IronPort-AV: E=Sophos;i="5.28,330,1464678000"; d="scan'208";a="206802594" Received: from unknown (HELO Ironmsg04-L.qualcomm.com) ([10.53.140.111]) by wolverine01.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Jul 2016 07:27:02 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8220"; a="1159258038" Received: from nasanexm02g.na.qualcomm.com ([10.85.0.88]) by Ironmsg04-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 08 Jul 2016 07:27:01 -0700 Received: from euamsexm01a.eu.qualcomm.com (10.251.127.40) by nasanexm02g.na.qualcomm.com (10.85.0.88) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 8 Jul 2016 07:27:00 -0700 Received: from potku.adurom.net (10.80.80.8) by euamsexm01a.eu.qualcomm.com (10.251.127.40) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 8 Jul 2016 16:26:54 +0200 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kalle Valo In-Reply-To: <20160706193417.13080-1-toke@toke.dk> To: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= CC: , , , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Tim Shepard , Felix Fietkau Message-ID: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01G.na.qualcomm.com (10.85.0.33) To euamsexm01a.eu.qualcomm.com (10.251.127.40) X-Mailman-Approved-At: Mon, 28 Nov 2016 08:47:10 -0500 Subject: Re: [Make-wifi-fast] [v3] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Fri, 08 Jul 2016 14:27:46 -0000 X-Original-Date: Fri, 8 Jul 2016 16:26:54 +0200 X-List-Received-Date: Fri, 08 Jul 2016 14:27:46 -0000 Toke Høiland-Jørgensen wrote: > This switches ath9k over to using the mac80211 intermediate software > queueing mechanism for data packets. It removes the queueing inside the > driver, except for the retry queue, and instead pulls from mac80211 when > a packet is needed. The retry queue is used to store a packet that was > pulled but can't be sent immediately. > > The old code path in ath_tx_start that would queue packets has been > removed completely, as has the qlen limit tunables (since there's no > longer a queue in the driver to limit). > > Based on Tim's original patch set, but reworked quite thoroughly. > > Cc: Tim Shepard > Cc: Felix Fietkau > Signed-off-by: Toke Høiland-Jørgensen Nice work. Because this is such a significant change, and to maximise testing time, I'm planning to queue this for 4.9 (so I would apply this to ath-next in 3-4 weeks after the merge window closes). But anyone who wants to test this can use master-pending branch from my ath.git tree (uses wireless-testing as the baseline). Sounds good? Testing and review feedback very welcome! -- Sent by pwcli https://patchwork.kernel.org/patch/9216993/