From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7E4C83B29D for ; Fri, 22 Nov 2019 07:27:59 -0500 (EST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1iY82Y-00033L-FQ; Fri, 22 Nov 2019 13:27:58 +0100 Message-ID: From: Johannes Berg To: Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, toke@redhat.com, nbd@nbd.name, yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com Date: Fri, 22 Nov 2019 13:27:55 +0100 In-Reply-To: <20191119060610.76681-3-kyan@google.com> (sfid-20191119_070625_522904_ADC19544) References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-3-kyan@google.com> (sfid-20191119_070625_522904_ADC19544) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Make-wifi-fast] [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2019 12:27:59 -0000 On Mon, 2019-11-18 at 22:06 -0800, Kan Yan wrote: > > +#define HE_GROUP_IDX(_streams, _gi, _bw) \ > + (IEEE80211_HE_GROUP_0 + \ > + IEEE80211_HE_MAX_STREAMS * 2 * (_bw) + \ > + IEEE80211_HE_MAX_STREAMS * (_gi) + \ > + (_streams) - 1) I'll also fix that to be " * 3" instead of 2, since there are 3 possible _gi values. johannes