From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from webmail.newmedia-net.de (nm.newmedia-net.de [217.113.179.122]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4B0F13B25D for ; Fri, 8 Jul 2016 14:24:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To; bh=EInXAnJW+fyA7u9ANo4QOzbLxjDhTq5sWrDe9YpMFd4=; b=PnxIZjvJwFSnn1pw+9cGYAyRWmHxOn51chUkLpC7I36i+4rOvVLREjcfHBI9TU9ptPusS8uTXwGLev06YHmrQuPkaKjQYNRYJYaCQg7mNZFTNFWhsoYcweoTTT0CMqqA6bbzoVu3kAy/j6IwjAxHrDy8TEUaHoUzmn67bh8IsEg=; To: Felix Fietkau , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= References: <87wpkwktx9.fsf@toke.dk> <112300e0-7d39-0c4c-45c9-158651f0c0ed@nbd.name> <87lh1cksao.fsf@toke.dk> Cc: Kalle Valo , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org, Tim Shepard From: Sebastian Gottschall Message-ID: User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 93.195.8.202 X-SA-Exim-Mail-From: s.gottschall@dd-wrt.com X-Spam-Checker-Version: SpamAssassin 3.1.9 (2007-02-13) on webmail.newmedia-net.de X-Spam-Level: X-Spam-Status: No, score=-2.5 required=4.0 tests=ALL_TRUSTED,BAYES_00, DNS_FROM_AHBL_RHSBL,RATWARE_GECKO_BUILD autolearn=no version=3.1.9, No X-SA-Exim-Version: 4.2.1 (built Thu, 26 May 2011 15:22:33 +0200) X-SA-Exim-Scanned: Yes (on webmail.newmedia-net.de) X-NMN-MailScanner-Information: Please contact the ISP for more information X-NMN-MailScanner-ID: 1bLaRc-0000iR-0B X-NMN-MailScanner: Found to be clean X-NMN-MailScanner-From: s.gottschall@dd-wrt.com X-Received: from [93.195.8.202] (helo=[172.29.0.250]) by webmail.newmedia-net.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1bLaRc-0000iR-0B; Fri, 08 Jul 2016 20:24:08 +0200 X-Mailman-Approved-At: Mon, 28 Nov 2016 08:47:10 -0500 Subject: Re: [Make-wifi-fast] [v3] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Fri, 08 Jul 2016 18:24:18 -0000 X-Original-Date: Fri, 8 Jul 2016 20:24:08 +0200 X-List-Received-Date: Fri, 08 Jul 2016 18:24:18 -0000 for me it crashes on wds sta on 3.18 kernels. need to solder a serial to get more logs Am 08.07.2016 um 18:31 schrieb Felix Fietkau: > On 2016-07-08 18:28, Toke Høiland-Jørgensen wrote: >> Felix Fietkau writes: >> >>> On 2016-07-08 17:53, Toke Høiland-Jørgensen wrote: >>>> Kalle Valo writes: >>>> >>>>> Toke Høiland-Jørgensen wrote: >>>>>> This switches ath9k over to using the mac80211 intermediate software >>>>>> queueing mechanism for data packets. It removes the queueing inside the >>>>>> driver, except for the retry queue, and instead pulls from mac80211 when >>>>>> a packet is needed. The retry queue is used to store a packet that was >>>>>> pulled but can't be sent immediately. >>>>>> >>>>>> The old code path in ath_tx_start that would queue packets has been >>>>>> removed completely, as has the qlen limit tunables (since there's no >>>>>> longer a queue in the driver to limit). >>>>>> >>>>>> Based on Tim's original patch set, but reworked quite thoroughly. >>>>>> >>>>>> Cc: Tim Shepard >>>>>> Cc: Felix Fietkau >>>>>> Signed-off-by: Toke Høiland-Jørgensen >>>>> Nice work. >>>> Thanks :) >>>> >>>>> Because this is such a significant change, and to maximise testing >>>>> time, I'm planning to queue this for 4.9 (so I would apply this to >>>>> ath-next in 3-4 weeks after the merge window closes). But anyone who >>>>> wants to test this can use master-pending branch from my ath.git tree >>>>> (uses wireless-testing as the baseline). Sounds good? >>>> Sounds good to me. I'm planning on backporting this and Michael's >>>> mac80211 FQ-CoDel patches to 4.4 and post them for inclusion in LEDE. >>>> Hopefully that will get it some more testing as well. >>> I've pushed a backport of this into my LEDE staging tree: >>> https://git.lede-project.org/?p=lede/nbd/staging.git;a=summary >> Awesome! What about the FQ-CoDel mac80211 patches themselves? I have a >> tree where I've separated out the needed patches and rebased them on >> mainline 4.4.9. Can I post that somewhere (or just email you the series) >> and get you to include those as well? Or do I just dump the patch files >> into the LEDE patches dir and send that as a patch to LEDE? (I see your >> patch also refreshed subsequent patches; is there a script to do that >> automatically?) > You don't need to do anything here. LEDE does not use mac80211 and > drivers from the kernel tree, it's built using backports. > It's currently using a backports snapshot that I built myself from > wireless-testing 2016-06-20, which already includes FQ-Codel. > > - Felix > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Berliner Ring 101, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Geschäftsführer: Peter Steinhäuser, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565