From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <johannes@sipsolutions.net>
Received: from sipsolutions.net (s3.sipsolutions.net
 [IPv6:2a01:4f8:191:4433::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 3DFFC3CB3A
 for <make-wifi-fast@lists.bufferbloat.net>;
 Fri, 22 Nov 2019 08:00:05 -0500 (EST)
Received: by sipsolutions.net with esmtpsa
 (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
 (Exim 4.92.3) (envelope-from <johannes@sipsolutions.net>)
 id 1iY8Xa-0003lh-4d; Fri, 22 Nov 2019 14:00:02 +0100
Message-ID: <dea9da1dd31900306c886c308c555691552290f5.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@redhat.com>, Kan Yan
 <kyan@google.com>
Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, 
 nbd@nbd.name, yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org, 
 rmanohar@codeaurora.org, kevinhayes@google.com
Date: Fri, 22 Nov 2019 14:00:01 +0100
In-Reply-To: <87tv6w3w92.fsf@toke.dk>
References: <20191119060610.76681-1-kyan@google.com>
 <20191119060610.76681-3-kyan@google.com>
 <3e7bea0cc643714ec90978a7999022544a39b118.camel@sipsolutions.net>
 <87tv6w3w92.fsf@toke.dk>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Make-wifi-fast] [PATCH v11 2/4] mac80211: Import airtime
 calculation code from mt76
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Fri, 22 Nov 2019 13:00:05 -0000


> Well, one calculates bitrates while the other calculates airtime? ;)

:)

> But yeah, I get what you mean. I think Felix went through quite some
> pains to structure this code to avoid divisions in the fast path. I
> guess that is the main blocker for cfg80211_calculate_bitrate() to be
> used instead (assuming we do want to consolidate them eventually). Not
> sure if that can be fixed easily though?

We could also do it the other way around?

Or maybe we should keep both and use them as a sanity check for each
other :P

johannes