From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 8E8583B2A4 for ; Thu, 19 Sep 2019 14:03:27 -0400 (EDT) Received: by mail-pf1-x442.google.com with SMTP id y22so2819390pfr.3 for ; Thu, 19 Sep 2019 11:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eero.com; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=FA0E4Xd1CxRoSy79h+C7G59jiUefZolA8vrNTdNN3WE=; b=QlvCe6C3s9Gkpi4E8pUbehQGVbcnFvQOu0RB6GI4xvf6YfpIMv7E4SAPwrm+cazZrv erobVzn69aaA11K2D0g/XfyNNeqNt07ZTS4zpbIgXwDfcrG5E/n5j4bWOwApuqWHucA2 x5/3YG4OYttEN6GOvDPZR0PLilsvKiKfSsih8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=FA0E4Xd1CxRoSy79h+C7G59jiUefZolA8vrNTdNN3WE=; b=PrKOuJpZT+rUAEolrg09aVMOxKAIsuUqeeUsxeDwvrlFF/2sheOjQiOsqDKAjgvVqj SZEQW4SS/9y7D4wEEx/3GtEQdKc7671v4uH2rINuteimE2CBrLBpn+YIQgecQt/4Ro9f 1qYgDVl7KLaQe81vyHxS9XI+Jt/0pYGhFQc4lH36W+Wn+T/H9q3JyLrh3njVJI6TGuzL tc5cUSLCzekWlXhXUI/i+iheLXa2eR/JLU9/73Y6A+ey9KnoxqQelmGm5+PIjgqpHVh5 ZbG2+A/d9efqKvWhcZAdXhGQ5wS3aHMTeSr5T5YVwdwrWLq8jgWCorGwTM/SzFhBu4le bq/A== X-Gm-Message-State: APjAAAXlJ/TQVP40V9qaz5eVWnmxC+0r0p8LnBEiyLaqvw1NcD1ucKjh OxOuTkJAq1OGj1JCMgNI1vVX0Q== X-Google-Smtp-Source: APXvYqzcie3HQAduAjI1S9tPW+WWCEXJ2wp/wDJWHll/2lI5z0jD0Ao34khCRKDh5pmU8cuQYrlahQ== X-Received: by 2002:a17:90a:cf0c:: with SMTP id h12mr4951489pju.110.1568916206762; Thu, 19 Sep 2019 11:03:26 -0700 (PDT) Received: from [10.0.2.15] (eero.static.monkeybrains.net. [199.116.72.162]) by smtp.gmail.com with ESMTPSA id w21sm6019533pgj.36.2019.09.19.11.03.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 11:03:26 -0700 (PDT) From: Peter Oh To: Ben Greear , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Johannes Berg Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, John Crispin , Lorenzo Bianconi , Felix Fietkau References: <156889576422.191202.5906619710809654631.stgit@alrua-x1> <156889576869.191202.510507546538322707.stgit@alrua-x1> <879913e9-4254-1381-07f6-d860fb0b8de0@candelatech.com> Message-ID: Date: Thu, 19 Sep 2019 11:03:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Mailman-Approved-At: Thu, 19 Sep 2019 14:14:26 -0400 Subject: Re: [Make-wifi-fast] [PATCH RFC/RFT 4/4] mac80211: Apply Airtime-based Queue Limit (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 18:03:27 -0000 On 9/19/19 10:54 AM, Peter Oh wrote: > > On 9/19/19 10:46 AM, Ben Greear wrote: >> On 9/19/19 10:44 AM, Peter Oh wrote: >>> On 9/19/19 5:22 AM, Toke Høiland-Jørgensen wrote: >>>> From: Toke Høiland-Jørgensen >>>> >>>> This patch ports that idea over to mac80211. The basic idea is simple >>>> enough: Whenever we dequeue a packet from the TXQs and send it to the >>>> driver, we estimate its airtime usage, based on the last recorded >>>> TX rate >>>> of the station that packet is destined for. >>> >>> The way to decide the last recorded TX rate could be vary among >>> drivers. In terms of ath10k driver and FW, they use 4 PPDUs to >>> update the Tx rate. Isn't it too small sampling number to be used >>> for AQL? >> >> Probably it is not exactly the last 4 either, since the report comes >> back indirectly and not >> synchronized with the tx path? >> The point of my question is "the last recorded Tx rate is derived from small number of PPDUs and if it's OK to use it for AQL calculation or not". Thanks, Peter