From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 430AC3B2A4 for ; Thu, 19 Sep 2019 13:54:15 -0400 (EDT) Received: by mail-pf1-x441.google.com with SMTP id y72so2768781pfb.12 for ; Thu, 19 Sep 2019 10:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eero.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=nKKtMJgm2T8OQpNNkegrSmUFwcFcES0Bmbw8lt6ta2E=; b=FvGCWlOA83AdVjinet8cdNHH9U4kf0RnYxo/mg+ua/u0voG5RDgPRApc6YFKIfMxIN ptPYQj1m+IUtIrUJ/JTFOgZtM/V7Xevnawc63U4byD9Khz8STqtmJkciIFtac447xhp7 RWebBtMhKaKi8QJQX0wQLMJ4ze40ThS+joIq8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=nKKtMJgm2T8OQpNNkegrSmUFwcFcES0Bmbw8lt6ta2E=; b=XbT1dtKMOfDwYS/FwO6Nisq/cCJSfDb7tox1if4Wi9k6q9BQjDy8ngn96beJE6bf0R aN6VuSM75Z43ucDFtW5vx+l69r0VAQWgkoHerU3uP60iS41Si4oQSRnLw2y2+1uO8pow uNk88TP1YzioCIZrlHafvl428briuCaUut0xyxAKTbRbftGlLKIfkvoe25SOdU/Ut/8w 70h9zp+k3kxRN/m83mrKycjhExQLRVFKvfz3qbxizlBeHfw+kkAKbEz25vsxX8y7TJJj O/RRFw5IgcdpZrM2dz+35Zm+OIWUDYPU1IGoTA4naal7WabGHlITgvl+VpmbKzmEIaNw fdew== X-Gm-Message-State: APjAAAX/GswWxFKI6/ydsM5kWEypajSrAjyvosYIau/5Aks1jZtVXQQ9 857vo95f170NRPoBRd+OVQ4HFw== X-Google-Smtp-Source: APXvYqzZ5LcSkpUvblvaEwlV81X52GwDdgv95K7Lw8XdTpYQYq1oEkyuoiCYd3xViJ5enTl1fnZQ4w== X-Received: by 2002:a63:4562:: with SMTP id u34mr10150235pgk.288.1568915654364; Thu, 19 Sep 2019 10:54:14 -0700 (PDT) Received: from [10.0.2.15] (eero.static.monkeybrains.net. [199.116.72.162]) by smtp.gmail.com with ESMTPSA id c14sm13534604pfm.179.2019.09.19.10.54.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 10:54:13 -0700 (PDT) To: Ben Greear , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Johannes Berg Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, John Crispin , Lorenzo Bianconi , Felix Fietkau References: <156889576422.191202.5906619710809654631.stgit@alrua-x1> <156889576869.191202.510507546538322707.stgit@alrua-x1> <879913e9-4254-1381-07f6-d860fb0b8de0@candelatech.com> From: Peter Oh Message-ID: Date: Thu, 19 Sep 2019 10:54:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <879913e9-4254-1381-07f6-d860fb0b8de0@candelatech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Mailman-Approved-At: Thu, 19 Sep 2019 13:57:17 -0400 Subject: Re: [Make-wifi-fast] [PATCH RFC/RFT 4/4] mac80211: Apply Airtime-based Queue Limit (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 17:54:15 -0000 On 9/19/19 10:46 AM, Ben Greear wrote: > On 9/19/19 10:44 AM, Peter Oh wrote: >> On 9/19/19 5:22 AM, Toke Høiland-Jørgensen wrote: >>> From: Toke Høiland-Jørgensen >>> >>> This patch ports that idea over to mac80211. The basic idea is simple >>> enough: Whenever we dequeue a packet from the TXQs and send it to the >>> driver, we estimate its airtime usage, based on the last recorded TX >>> rate >>> of the station that packet is destined for. >> >> The way to decide the last recorded TX rate could be vary among >> drivers. In terms of ath10k driver and FW, they use 4 PPDUs to update >> the Tx rate. Isn't it too small sampling number to be used for AQL? > > Probably it is not exactly the last 4 either, since the report comes > back indirectly and not > synchronized with the tx path? > The point of my question is "the last recorded Tx raith small nte is derived wumber of PPDUs and if it's ok to use it for AQL calculation or not". Thanks, Peter