<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
<pre wrap="">On Tue, Oct 11, 2011 at 12:27:17PM +0200, David Täht wrote:
</pre>
<blockquote type="cite" style="color: rgb(0, 0, 0);">
<pre wrap=""><span class="moz-txt-citetags">> </span>On my list already would be "an analysis of the effects of broken sack
<span class="moz-txt-citetags">> </span>processing on linux 2.4.24-3.1", of which I <b class="moz-txt-star"><span class="moz-txt-tag">*</span>think<span class="moz-txt-tag">*</span></b> I've captured
<span class="moz-txt-citetags">> </span>multiple examples of in the raw traces I've been collecting for
<span class="moz-txt-citetags">> </span>months... (so if anyone is interested in the raw data, I can provide)
</pre>
</blockquote>
<pre wrap="">Do you have any more information? The only thing I could find online was that
there were SACK issues that were supposed to be fixed by 2.6.16; nothing
about a fix in 3.1 or post-3.1.
</pre>
This was a typo on my part - 2.6.24-3.1, not 2.4<br>
<br>
<br>
The specific commit that concerned me was this one. I had seen
multiple cases of odd behavior (basically tcp sacking like crazy
until the cwr collapses or a tcp reset) that I *think* this fix
explains. <br>
<br>
<br>
<br>
commit f779b2d60ab95c17f1e025778ed0df3ec2f05d75<br>
Author: Zheng Yan <a class="moz-txt-link-rfc2396E" href="mailto:zheng.z.yan@intel.com"><zheng.z.yan@intel.com></a><br>
Date: Sun Sep 18 22:37:34 2011 -0400<br>
<br>
tcp: fix validation of D-SACK<br>
<br>
D-SACK is allowed to reside below snd_una. But the corresponding
check<br>
in tcp_is_sackblock_valid() is the exact opposite. It looks like
a typo.<br>
<br>
Signed-off-by: Zheng Yan <a class="moz-txt-link-rfc2396E" href="mailto:zheng.z.yan@intel.com"><zheng.z.yan@intel.com></a><br>
Acked-by: Eric Dumazet <a class="moz-txt-link-rfc2396E" href="mailto:eric.dumazet@gmail.com"><eric.dumazet@gmail.com></a><br>
Signed-off-by: David S. Miller <a class="moz-txt-link-rfc2396E" href="mailto:davem@davemloft.net"><davem@davemloft.net></a><br>
<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
Dave Täht
</pre>
</body>
</html>