[Cake] Long-RTT broken again

Toke Høiland-Jørgensen toke at toke.dk
Tue Nov 3 06:45:49 EST 2015

Sebastian Moeller <moeller0 at gmx.de> writes:

>> BUG_ON I put in the category of "Never test for a condition you don't
>> know how to handle" ;-)  Now that the off-by-one has been stomped on I'm
>> going to stick my neck out and say that bin_cnt > 8 implies something
>> has stomped on our config structure and we really shouldn't be trusting
>> anything in it.  Goodness knows what our skb queues are like...and err,
>> help!  Also note that the correctly written BUG_ON didn't explode for
>> many months.
> 	Well, not my call, but I have seen discussions on LKML about
> 	this topic with the general gist that a BUG_ON needs to be
> 	justified, and only be there is the situation is not
> 	salvageable. After all we take down a whole machine that might
> 	be doing something really really important...

The right thing to do would be to reject the netlink request and not
change anything.


More information about the Cake mailing list