[Cake] Fixing iproute2 compile

[Kevin Darbyshire-Bryant]

I think the problem is we're not including stddef.h which defines offsetof.  Later versions of iproute include a def in Utils.h but that wasn't in v4.0.0 which is what tokes repo is based on. Tc-adv is a bit more recent. 

--
Cheers,

Kevin at Darbyshire-Bryant.me.uk
Sent from my phone, apologies for brevity, spelling & top posting

> On 19 Oct 2015, at 17:41, Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk> wrote:
> 
> Hold the phone...
> 
> My guess is a difference in definition of offsetof as potentially defined in tc/include/Utils.h
> 
> But very hard to tell on my phone!
> 
> --
> Cheers,
> 
> Kevin at Darbyshire-Bryant.me.uk
> Sent from my phone, apologies for brevity, spelling & top posting
> 
>> On 19 Oct 2015, at 17:01, Toke Høiland-Jørgensen <toke at toke.dk> wrote:
>> 
>> So finally got iproute2 to compile out of the kau.toke.dk repo. The
>> patch below was needed to cake. Posting it here rather than just
>> committing in the hope of getting someone (Jonathan?) to take a look at
>> it and fix it everywhere it's needed :)
>> 
>> -Toke
>> 
>> diff --git a/tc/q_cake.c b/tc/q_cake.c
>> index 4d64405..1384a46 100644
>> --- a/tc/q_cake.c
>> +++ b/tc/q_cake.c
>> @@ -495,7 +496,7 @@ static int cake_print_xstats(struct qdisc_util *qu, FILE *f,
>> 
>>   } else if (stnc->version >= 1 && stnc->version < 0xFF
>>               && stnc->max_tins == TC_CAKE_MAX_TINS
>> -                && RTA_PAYLOAD(xstats) >= offsetof(*stnc, capacity_estimate))
>> +                && RTA_PAYLOAD(xstats) >= offsetof(typeof(*stnc), capacity_estimate))
>>   {
>>       int i;
>> 
>> _______________________________________________
>> Cake mailing list
>> Cake at lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
> _______________________________________________
> Cake mailing list
> Cake at lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3062 bytes
Desc: not available
URL: <https://lists.bufferbloat.net/pipermail/cake/attachments/20151019/753c59ce/attachment-0002.bin>