[Cake] Dropping last_len from stats collection & display.

moeller0 moeller0 at gmx.de
Wed Jun 1 11:05:48 EDT 2016


Hi Kevin,


> On Jun 1, 2016, at 13:40 , Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk> wrote:
> 
> Gentlemen,
> 
> Two pull requests https://github.com/dtaht/sch_cake/pull/26  & https://github.com/dtaht/tc-adv/pull/11
> 
> These drop the collection of last packet's length for stats purposes.
> 
> I've not dropped maxlen as I have personally found that *incredibly* useful in working out what overheads linux has already accounted for on a variety of connections.  It is also a useful indicator of GSO/GRO activity.

	I fully concur overhead deduction is hard any piece of information can help, also I note that fq_codel reports the same and I believe we all agree that Eric Dumazet knows what he is doing ;)

Best Regards
	Sebastian

> 
> Not updating another variable (memory write) for each packet may help cake's CPU usage a little.
> 
> Done in a backwards compatible way for tc.
> 
> Please ACK/NACK as you see fit.
> 
> Kevin
> _______________________________________________
> Cake mailing list
> Cake at lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



More information about the Cake mailing list