[Cake] BUG_ON vs WARN_ON

[Kevin Darbyshire-Bryant]

On 05/10/16 16:42, Jonathan Morton wrote:
>
>> On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant
>> <kevin at darbyshire-bryant.me.uk> wrote:
>>
>> How amenable are you to changing all 4 BUG_ON instances in cake to
>> WARN_ON?
>>
>> Linus isn't a complete fan and I'm thinking that producing a stack
>> trace and trying to carry on is more helpful to a remote accessed,
>> no serial interface type device than just killing the kernel dead.
>>
>> Quite possibly other bad things(tm) will happen shortly after...or
>> maybe there will be enough time look at dmesg for that stack
>> trace.
>
> The two in cake_heap_swap() can probably go away completely - they
> were there to make sure the heap algorithms were working correctly.
> They never did trigger, as it happens.
>
> The other two are genuine serious bugs (array overflow) if they ever
> trigger.  It’s safer to leave them as-is.

Fair enough :-)  I wonder what it was that caused yesterday's issues?  I 
really must try again when I've more time to get proper access.

Kevin

>
> - Jonathan Morton
>