[Cake] commit 0d8f30 breaks ingress mode

[George Amanakis]

Dear All,

merry christmas to the list members!

I was doing some real-world testing using dslreports.com/speedtest with
my 10/2mbps comcast cable line, and found out by bisecting that
commit 0d8f30faa3d4bb2bc87a382f18d8e0f3e4e56ea (Dynamically adjust
sojourn target according to flow count and serialisation delay)
deteriorates latency even in ingress mode. 

In real-world, with 16 flows downloading from dslreports.com ping times
are >500ms. This has never been the case with ingress mode before. I
don't know yet why this didn't show up with the veth scripts. 

In sch_cake.c changing over_target to its pre 0d8f30 value "sojourn >
p->target" brings ping times down to <50ms.

tc -s qdisc show:
qdisc cake 801f: dev ens4 root refcnt 2 bandwidth 12200Kbit diffserv3
dual-dsthost wash ingress rtt 100.0ms noatm overhead 18 via-ethernet
mpu 64 
 Sent 23963379 bytes 17137 pkt (dropped 35, overlimits 32166 requeues
0) 
 backlog 0b 0p requeues 0 
 memory used: 920832b of 4Mb
 capacity estimate: 12200Kbit
                 Bulk   Best Effort      Voice
  thresh     762496bit   12200Kbit    3050Kbit
  target        23.8ms       5.0ms       6.0ms
  interval     118.8ms     100.0ms     101.0ms
  pk_delay     527.5ms       594us        42us
  av_delay     315.3ms       144us         0us
  sp_delay         1us         1us         0us
  pkts           16197         954          21
  bytes       23412978      600744        2647
  way_inds           0           0           0
  way_miss         105          62           3
  way_cols           0           0           0
  drops             35           0           0
  marks            335           3           0
  ack_drop           0           0           0
  sp_flows           0           0           0
  bk_flows           0           0           1
  un_flows           0           0           0
  max_len         4542        3392         254

qdisc cake 8020: dev ens3 root refcnt 2 bandwidth 2500Kbit diffserv3
dual-srchost nat wash ack-filter rtt 100.0ms noatm overhead 18 via-
ethernet mpu 64 
 Sent 2890199 bytes 15496 pkt (dropped 20, overlimits 4773 requeues 0) 
 backlog 0b 0p requeues 0 
 memory used: 41764b of 4Mb
 capacity estimate: 2500Kbit
                 Bulk   Best Effort      Voice
  thresh     156248bit    2500Kbit     625Kbit
  target       116.3ms       7.3ms      29.1ms
  interval     232.6ms     102.3ms     124.1ms
  pk_delay         0us      70.0ms         0us
  av_delay         0us      45.2ms         0us
  sp_delay         0us       5.7ms         0us
  pkts               0       15515           1
  bytes              0     2891673          42
  way_inds           0           0           0
  way_miss           0         141           1
  way_cols           0           0           0
  drops              0           0           0
  marks              0          55           0
  ack_drop           0          20           0
  sp_flows           0           0           0
  bk_flows           0           1           0
  un_flows           0           0           0
  max_len            0        4542          42

Could somebody confirm this? 


George