Remember that the upstream folks regard checkpatch as advice, not a rule, so don't go overboard changing other code to comply with checkpatch (or if you do make a bunch of changes to other code, make it a separate commit, before your functional changes) David Lang