[Cake] new patchset for upstream net-next

[Kevin Darbyshire-Bryant]

> On 26 Nov 2017, at 18:22, Dave Taht <dave at taht.net> wrote:
> 
> Toke Høiland-Jørgensen <toke at toke.dk> writes:
> 
>> gamanakis at gmail.com writes:
>> 
>>> Just finished building, setting both sch_cake and nf_conntrack as
>>> integral succeeds. Setting nf_conntrack as module fails with sch_cake
>>> as integral (makes sense).
>> 
>> So this probably needs either a Kconfig dependency or an ifdef?
> 
> I don't really know. We want cake to compile without conntrack
> (it's expensive).

I’m slightly confused by that statement - The conntrack lookup is controlled per instance and is one conditional in the code path:

if (flow_mode & CAKE_FLOW_NAT_FLAG)
                cake_update_flowkeys(&keys, skb);

Admittedly cake_update_flowkeys is pretty gnarly but it’s only called if you configure the qdisc with ‘nat’.  What am I misunderstanding?

> 
>> 
>> -Toke
>> _______________________________________________
>> Cake mailing list
>> Cake at lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
> _______________________________________________
> Cake mailing list
> Cake at lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake