[Cake] Cake tree unreadable

Toke Høiland-Jørgensen toke at toke.dk
Wed Nov 29 07:27:59 EST 2017

Dave Taht <dave at taht.net> writes:

> A flag day here is feasible. I will fiddle along the lines you
> describe.

FWIW I don't think the history is that bad. Sure, there are a bunch of
merge commits, but picking out the real ones is not that difficult
(unless you are using the github web interface, I guess, but that sucks
for most things anyway). I'm not sure rewriting history in the existing
branch is worth the hassle. We're going to reset history anyway once
it's been upstreamed.

If you *are* going to rewrite history, please at least do it in a
separate branch instead of force pushing to an existing one...

> I'm toying with the idea of fixing xstats in a separate branch. I
> really hate the idea of breaking backward compatability here, but I do
> suspect it will be a barrier to upstreaming, and it is, quite
> inefficient.

I'm not sure this will actually be enough of a backwards compatibility
break to warrant the term 'flag day'. I.e., it won't affect outside
behaviour. Sure, you need to update userspace and the kernel module
together, but you kinda need to do that anyway when new features are
added. And for LEDE, we'll just push updates to both packages at the
same time, which should give new images and even `opkg update` a
consistent view...

So I'd say go ahead and break things. The worst thing that can happen is
that some users will lose the statistics until they update their
userspace tool...


More information about the Cake mailing list