[Cake] [PATCH] Keep an internal counter for total queue length

Jonathan Morton chromatix99 at gmail.com
Fri Jul 6 09:23:32 EDT 2018

> On 6 Jul, 2018, at 4:21 pm, Toke Høiland-Jørgensen <toke at toke.dk> wrote:
>> I'm handling it without using any extra permanent state, just making
>> use of what's already there. Take a look at latest commit.
> Yup, that also fixes the infinite loop issue. I'm fine with doing it
> this way; however, it doesn't handle the other places where we check
> whether sch->q.qlen is nonzero. Are you sure that is not going to give
> us more problems down the road? :)

The other places are checking whether the queue is empty for the purposes of updating the shaper state.  They are therefore much less critical, and I think self-correcting.

 - Jonathan Morton

More information about the Cake mailing list