[Cake] [PATCH net-next] sch_cake: Make gso-splitting configurable from userspace

Dave Taht dave.taht at gmail.com
Thu Jul 26 22:45:09 EDT 2018

I expect the first part of this patch to generate no controversy,
as being able to enable configure gso-splitting on or off in all
use cases of cake is a goodness.

But: I expect the single line re-enabling cake's fielded default of
always splitting gro and gso packets, in shaped or unshaped mode, back
into packets, to reduce my email systems' hard disk inbox to a barren,
burnt cylinder, even if it is made easy to override thusly:

tc qdisc replace dev whatever root cake no-split-gso

While I agree that gro/gso is needed at 10gigE+ speeds, I feel
offering an option to disable splitting to those users trying to run
cake at those speeds is better than the alternative of forcing users
running at 1Gbit, 100mbit, 10mbit and below, with and without pause
frames, shaped or unshaped, to remember to split-gso.

While I have assembled tons of data in use cases ranging from nearly 0
to a gbit, the first, and most compelling argument I can make is
made in the commit that follows, where allowing GSO/GRO superpackets
triples the size of the underlying BQL when running at a gbit.

Dave Taht (1):
  sch_cake: Make gso-splitting configurable

 net/sched/sch_cake.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)


More information about the Cake mailing list