[Cake] [PATCH 2/2] tc print_uint format fixes

Toke Høiland-Jørgensen toke at toke.dk
Sun Mar 11 17:22:21 EDT 2018

Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk> writes:

>> On 11 Mar 2018, at 20:50, Toke Høiland-Jørgensen <toke at toke.dk> wrote:
>> Kevin Darbyshire-Bryant <ldir at darbyshire-bryant.me.uk> writes:
>>> Signed-off-by: Kevin Darbyshire-Bryant <ldir at darbyshire-bryant.me.uk>
>>> ---
>>> tc/tc_qdisc.c |  3 ++-
>>> tc/tc_util.c  | 24 ++++++++++++------------
>>> 2 files changed, 14 insertions(+), 13 deletions(-)
>> Care to submit this to upstream iproute2? Amending the commit message
>> with an explanation of why the change is needed and sending the same
>> patch to netdev at vger.kernel.org should be enough, I think :)
> I wanted a sanity check first :-)  And there’s more to do.  A LOT more!
> Is it sane?

Apart from the fact that it is really grating that a function called
"print_uint()" needs this weird 64-bit format string include. But that
is probably an issue that upstream should deal with.

Also, the inttypes.h include is missing from tc_util.c in your patch...

Other than that, compiles and works for me on x86_64...


More information about the Cake mailing list