[Cake] [PATCH 1/2] cake: print_uint format fixes

Stephen Hemminger stephen at networkplumber.org
Sun Mar 11 19:34:23 EDT 2018


On Sun, 11 Mar 2018 22:10:51 +0000
Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk> wrote:

>  negative?  
> 
> Tried it, and you’d sort of guess wrong.  I’ll write it up tomorrow ‘properly’ but ‘int’ is int length whereas uint is uint64 length.  On big endian it goes wrong.
> 
> Anyway, glad you’ve tested on something little endian.  I’ll try to submit a patch upstream as requested…very busy over next 3 days doing $dayjob so may take a little while.  Thanks for boosting confidence that I’ve not broken it on architectures it used to work on :-)

print_uint should be unsigned only.

When printing json your version won't work with negative values.


More information about the Cake mailing list