Compiling under net-next
Georgios Amanakis
g_amanakis at yahoo.com
Sun Mar 18 15:59:23 EDT 2018
Hello All,
I just received a notice that in archlinux running 4.16-rc1 cake fails
to build (https://aur.archlinux.org/packages/sch_cake-dkms). I can also
confirm the same error with net-next and the cobalt tree:
============8<============
DKMS make.log for sch_cake-r427.d2d6780 for kernel 4.16.0-rc1-
61deb7d0dddd (x86_64)
Sun Mar 18 10:08:24 IST 2018
make: Entering directory '/usr/lib/modules/4.16.0-rc1-
61deb7d0dddd/build'
CC [M] /var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: error:
initialization from incompatible pointer type [-Werror=incompatible-
pointer-types]
.init = cake_init,
^~~~~~~~~
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2708:11: note:
(near initialization for ‘cake_qdisc_ops.init’)
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: error:
initialization from incompatible pointer type [-Werror=incompatible-
pointer-types]
.change = cake_change,
^~~~~~~~~~~
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.c:2711:13: note:
(near initialization for ‘cake_qdisc_ops.change’)
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:323:
/var/lib/dkms/sch_cake/r427.d2d6780/build/sch_cake.o] Error 1
make: *** [Makefile:1549:
_module_/var/lib/dkms/sch_cake/r427.d2d6780/build] Error 2
make: Leaving directory '/usr/lib/modules/4.16.0-rc1-
61deb7d0dddd/build'
============8<============
I see that the init function type changed from (eg tbf_init):
static int tbf_init(struct Qdisc *sch, struct nlattr *opt)
to:
static int tbf_init(struct Qdisc *sch, struct nlattr *opt,
struct netlink_ext_ack *extack)
The same applies for the change function type (eg tbf_change), from:
static int tbf_change(struct Qdisc *sch, struct nlattr *opt)
to:
static int tbf_change(struct Qdisc *sch, struct nlattr *opt,
struct netlink_ext_ack *extack)
George
More information about the Cake
mailing list