[Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

Toke Høiland-Jørgensen toke at toke.dk
Tue May 1 17:54:01 EDT 2018

Eric Dumazet <eric.dumazet at gmail.com> writes:

> On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote:
>> Could you comment on specifically what you believe is broken in this,
>> please, so I can fix it in the same iteration?
> Apart from the various pskb_may_pull() this helper should not change skb layout.
> Ideally, the skb should be const and you would use
> skb_header_pointer() to make clear you do not ever write this skb.
> This would make the reviewer job pretty easy, as no side effect can
> possibly happen.

Gotcha. Will fix; thanks :)


More information about the Cake mailing list