[Cake] [PATCH net-next v7 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

David Miller davem at davemloft.net
Thu May 3 11:24:02 EDT 2018


From: Toke Høiland-Jørgensen <toke at toke.dk>
Date: Wed, 02 May 2018 17:11:03 +0200

> diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
> new file mode 100644
> index 000000000000..18bc147f12bc
> --- /dev/null
> +++ b/net/sched/sch_cake.c
> +static inline cobalt_time_t cobalt_get_time(void)
> +{
> +	return ktime_get_ns();
> +}

Please do not use inline in foo.c files, let the compiler decide.

> +static inline u32
> +cake_hash(struct cake_tin_data *q, const struct sk_buff *skb, int flow_mode)
> +{

Especially for this monster!  Yikes!


More information about the Cake mailing list