[Cake] [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

David Miller davem at davemloft.net
Sun May 13 20:09:48 EDT 2018

From: Toke Høiland-Jørgensen <toke at toke.dk>
Date: Tue, 08 May 2018 16:34:19 +0200

> +struct cake_flow {
> +	/* this stuff is all needed per-flow at dequeue time */
> +	struct sk_buff	  *head;
> +	struct sk_buff	  *tail;

Please do not invent your own SKB list handling mechanism.

Use a standard sk_buff_head.  If you don't need the locking etc., we
have interfaces like __skb_queue_head_init(), __skb_insert(), etc.
which will accomodate that.

> +static void cake_heapify(struct cake_sched_data *q, u16 i)
> +{
> +	static const u32 a = CAKE_MAX_TINS * CAKE_QUEUES;
> +	u32 m = i;
> +	u32 mb = cake_heap_get_backlog(q, m);

Please order local variables from longest to shortest line.

The entire submissions has this problem all over the place, please
correct it patch-series wide.

Thank you.

More information about the Cake mailing list