[Cake] [PATCH net-next v16 4/8] netfilter: Add nf_ct_get_tuple_skb callback

[kbuild test robot]

Hi Toke,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]
[also build test WARNING on v4.17-rc7]
[cannot apply to net-next/master next-20180529]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/sched-Add-Common-Applications-Kept-Enhanced-cake-qdisc/20180530-125240
config: i386-randconfig-a0-05291352 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   net/netfilter/core.c: In function 'nf_ct_get_tuple_skb':
>> net/netfilter/core.c:586:12: warning: assignment from incompatible pointer type
     get_tuple = rcu_dereference(skb_ct_get_tuple);
               ^
>> net/netfilter/core.c:589:18: warning: passing argument 1 of 'get_tuple' from incompatible pointer type
     ret = get_tuple(dst_tuple, skb);
                     ^
   net/netfilter/core.c:589:18: note: expected 'const struct sk_buff *' but argument is of type 'struct nf_conntrack_tuple *'
   net/netfilter/core.c:589:29: warning: passing argument 2 of 'get_tuple' from incompatible pointer type
     ret = get_tuple(dst_tuple, skb);
                                ^
   net/netfilter/core.c:589:29: note: expected 'struct nf_conntrack_tuple *' but argument is of type 'const struct sk_buff *'

vim +586 net/netfilter/core.c

   578	
   579	bool nf_ct_get_tuple_skb(struct nf_conntrack_tuple *dst_tuple,
   580				 const struct sk_buff *skb)
   581	{
   582		bool (*get_tuple)(const struct sk_buff *, struct nf_conntrack_tuple *);
   583		bool ret = false;
   584	
   585		rcu_read_lock();
 > 586		get_tuple = rcu_dereference(skb_ct_get_tuple);
   587		if (!get_tuple)
   588			goto out;
 > 589		ret = get_tuple(dst_tuple, skb);
   590	out:
   591		rcu_read_unlock();
   592		return ret;
   593	}
   594	EXPORT_SYMBOL(nf_ct_get_tuple_skb);
   595	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 28923 bytes
Desc: not available
URL: <https://lists.bufferbloat.net/pipermail/cake/attachments/20180530/82e58be8/attachment-0001.gz>