[Cake] [PATCH net 2/2] sch_cake: Make sure we can write the IP header before changing DSCP bits

Stephen Hemminger stephen at networkplumber.org
Thu Apr 4 15:35:36 EDT 2019

On Thu, 04 Apr 2019 15:01:33 +0200
Toke Høiland-Jørgensen <toke at redhat.com> wrote:

>  static u8 cake_handle_diffserv(struct sk_buff *skb, u16 wash)
>  {
> +	int wlen = skb_network_offset(skb);

In theory this could be negative, you should handle that?
Rather than calling may_pull() with a huge unsigned value.

More information about the Cake mailing list