[Cake] Upstream submission of dual-mode fairness patch

[Sebastian Moeller]

Mmmh,

Doesn't this look like ingress magic being applied selectively to the users based on number of flows? I thought that the idea behind the ingress keyword is to effectively shape harder the more bulk flows are coming in. 

Just asking...

Best regards
Sebastian

On March 3, 2019 8:19:00 AM GMT+01:00, Pete Heist <pete at heistp.net> wrote:
>Oops, sorry I didn’t notice this before but it’s the ingress keyword
>that makes the difference:
>
>qdisc cake 802c: dev ifbLink2 parent 1:1 bandwidth unlimited besteffort
>dual-dsthost nonat nowash ingress no-ack-filter no-split-gso rtt
>100.0ms raw overhead 0 
>
>IP1, 1 up: 46.8 Mbit
>IP2, 16 up: 46.8 Mbit
>IP1, 16 down: 41.9 Mbit
>IP2, 1 down: 51.1 Mbit
>
>qdisc cake 803a: dev ifbLink2 parent 1:1 bandwidth unlimited besteffort
>dual-dsthost nonat nowash no-ack-filter no-split-gso rtt 100.0ms raw
>overhead 0 
>
>IP1, 1 up: 46.6 Mbit
>IP2, 16 up: 46.5 Mbit
>IP1, 16 down: 46.4 Mbit
>IP2, 1 down: 46.5 Mbit
>
>Also, my setup is different in that I use cake as a leaf to either hfsc
>or htb. But, it’s adding the ingress keyword that causes the imbalance
>for me.
>
>> On Mar 2, 2019, at 11:20 AM, Pete Heist <pete at heistp.net> wrote:
>> 
>> Great, thanks for trying it. That strongly suggests a problem with
>the kernel (or driver) I’m using. Feels better to know it works as it
>should in recent kernels though...
>> 
>>> On Mar 2, 2019, at 5:47 AM, George Amanakis <gamanakis at gmail.com>
>wrote:
>>> 
>>> On Fri, 2019-03-01 at 22:02 -0500, George Amanakis wrote:
>>>> 
>>>> I will setup a vlan and try again.
>>>> 
>>> 
>>> I replicated Pete's VLAN setup, and I am getting fairness:
>>> 
>>> IP1,2 <---> router enp1s0 / router enp1s0.100 <---> server
>>> 
>>> IP1, 1 up:      46.73 mbit/s
>>> IP2, 32 up:     46.91
>>> IP1, 32 down:   46.70
>>> IP2, 1 down:    46.89
>>> 
>>> qdisc cake 8006: dev enp1s0.100 root refcnt 2 bandwidth 100Mbit
>>> diffserv3 dual-srchost nonat nowash no-ack-filter split-gso nofwmark
>>> rtt 100.0ms noatm overhead 4
>>> 
>>> qdisc cake 8002: dev ifb0 root refcnt 2 bandwidth 100Mbit diffserv3
>>> dual-dsthost nonat nowash no-ack-filter split-gso nofwmark rtt
>100.0ms
>>> noatm overhead 4
>>> 
>>> 
>>> 
>> 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.bufferbloat.net/pipermail/cake/attachments/20190303/5fb2d8c3/attachment.html>