[Cake] Upstream submission of dual-mode fairness patch

gamanakis at gmail.com gamanakis at gmail.com
Sun Mar 3 14:03:20 EST 2019


For the record, I can replicate it now. I also think that this behavior is expected.
There is a work-around but it seems like an awful hack:

----------8<----------
diff --git a/sch_cake.c b/sch_cake.c
index 733b897..08e08f4 100644
--- a/sch_cake.c
+++ b/sch_cake.c
@@ -2216,7 +2216,6 @@ retry:
                if (q->rate_flags & CAKE_FLAG_INGRESS) {
                        len = cake_advance_shaper(q, b, skb,
                                                  now, true);
-                       flow->deficit -= len;
                        b->tin_deficit -= len;
                }
                flow->dropped++;
----------8<----------


Then the results are:

IP1, 1 up:	47.18 mbit/s
IP2, 32 up:	46.99
IP1, 32 down:	40.98
IP2, 1 down:	41.34





More information about the Cake mailing list