[Cake] cake memory consumption

[Sebastian Gottschall]

the problem is. i tested restricting the memory to 4 mb. but it still 
runs oom. same memory consumption and from the qdisc show output i also 
see that just a few kilobytes are used in that pool.
so the problem with cake must be somewhere else. its not the buffer 
limit. i see values like memory used: 22176b of 4Mb which is really 
nothing. most qdiscs are 0 and unused in that setup

Am 17.09.2019 um 11:40 schrieb Toke Høiland-Jørgensen:
> Sebastian Gottschall <s.gottschall at newmedia-net.de> writes:
>
>> more simple patch
>>
>> --- sch_cake.c  (revision 41051)
>> +++ sch_cake.c  (working copy)
>> @@ -2691,7 +2691,7 @@
>>                   do_div(t, USEC_PER_SEC / 4);
>>                   q->buffer_limit = max_t(u32, t, 4U << 20);
>>           } else {
>> -               q->buffer_limit = ~0;
>> +               q->buffer_limit = 4U << 20;
>>           }
>>
>>           sch->flags &= ~TCQ_F_CAN_BYPASS;
> As Jonathan remarked, the right thing to do here is to use the
> memory_limit parameter to set a different limit when you setup the tree.
>
> Still, I count 35 instances of CAKE in your setup; even with a 4MB limit
> apiece, that is a total of 140 MB of potential packet memory. You'd need
> to set it as low as 1 or 2 MB to be completely sure that you won't run
> out of memory if they are all full...
>
> -Toke